fix(no-await-sync-query): prevent screen sync queries from using await

First, abstract reportError function. Then, create selector for MemberExpression queries.

Author: victorandcode

lib/rules/no-await-sync-query.js

@@ -21,18 +21,17 @@ module.exports = {
   },
 
   create: function(context) {
+    const reportError = node =>
+      context.report({
+        node,
+        messageId: 'noAwaitSyncQuery',
+        data: {
+          name: node.name,
+        },
+      });
     return {
-      [`AwaitExpression > CallExpression > Identifier[name=${SYNC_QUERIES_REGEXP}]`](
-        node
-      ) {
-        context.report({
-          node,
-          messageId: 'noAwaitSyncQuery',
-          data: {
-            name: node.name,
-          },
-        });
-      },
+      [`AwaitExpression > CallExpression > Identifier[name=${SYNC_QUERIES_REGEXP}]`]: reportError,
+      [`AwaitExpression > CallExpression > MemberExpression > Identifier[name=${SYNC_QUERIES_REGEXP}]`]: reportError,
     };
   },
 };

tests/lib/rules/no-await-sync-query.js

@@ -43,9 +43,9 @@ ruleTester.run('no-await-sync-query', rule, {
     })),
   ],
 
-  invalid:
+  invalid: [
     // sync queries with await operator are not valid
-    SYNC_QUERIES_COMBINATIONS.map(query => ({
+    ...SYNC_QUERIES_COMBINATIONS.map(query => ({
       code: `async () => {
         await ${query}('foo')
       }
@@ -56,4 +56,18 @@ ruleTester.run('no-await-sync-query', rule, {
         },
       ],
     })),
+
+    // sync queries in screen with await operator are not valid
+    ...SYNC_QUERIES_COMBINATIONS.map(query => ({
+      code: `async () => {
+        await screen.${query}('foo')
+      }
+      `,
+      errors: [
+        {
+          messageId: 'noAwaitSyncQuery',
+        },
+      ],
+    })),
+  ],
 });