refactor: disable autofix implementation

Author: emmenko

lib/rules/prefer-expect-query-by.js

@@ -82,16 +82,19 @@ module.exports = {
   create: context => ({
     CallExpression(node) {
       if (hasExpectWithWrongGetByQuery(node)) {
-        const nodesGetBy = mapNodesForWrongGetByQuery(node);
+        // const nodesGetBy = mapNodesForWrongGetByQuery(node);
         context.report({
           node: node.callee,
           messageId: 'expectQueryBy',
-          fix(fixer) {
-            return fixer.replaceText(
-              nodesGetBy[0],
-              nodesGetBy[0].name.replace(/^(get(All)?(.*))$/, 'query$2$3')
-            );
-          },
+          // TODO: we keep the autofixing disabled for now, until we figure out
+          // a better way to amend for the edge cases.
+          // See also the related discussion: https://github.com/Belco90/eslint-plugin-testing-library/pull/22#discussion_r335394402
+          // fix(fixer) {
+          //   return fixer.replaceText(
+          //     nodesGetBy[0],
+          //     nodesGetBy[0].name.replace(/^(get(All)?(.*))$/, 'query$2$3')
+          //   );
+          // },
         });
       }
     },

tests/lib/rules/prefer-expect-query-by.js

@@ -33,30 +33,26 @@ ruleTester.run('prefer-expect-query-by', rule, {
     ],
     []
   ),
-  invalid: getByVariants.reduce((invalidRules, queryName) => {
-    const fixedQueryName = queryName.replace('get', 'query');
-    return [
+  invalid: getByVariants.reduce(
+    (invalidRules, queryName) => [
       ...invalidRules,
       {
         code: `expect(${queryName}('Hello')).toBeInTheDocument()`,
         errors: [{ messageId: 'expectQueryBy' }],
-        output: `expect(${fixedQueryName}('Hello')).toBeInTheDocument()`,
       },
       {
         code: `expect(rendered.${queryName}('Hello')).toBeInTheDocument()`,
         errors: [{ messageId: 'expectQueryBy' }],
-        output: `expect(rendered.${fixedQueryName}('Hello')).toBeInTheDocument()`,
       },
       {
         code: `expect(${queryName}('Hello')).not.toBeInTheDocument()`,
         errors: [{ messageId: 'expectQueryBy' }],
-        output: `expect(${fixedQueryName}('Hello')).not.toBeInTheDocument()`,
       },
       {
         code: `expect(rendered.${queryName}('Hello')).not.toBeInTheDocument()`,
         errors: [{ messageId: 'expectQueryBy' }],
-        output: `expect(rendered.${fixedQueryName}('Hello')).not.toBeInTheDocument()`,
       },
-    ];
-  }, []),
+    ],
+    []
+  ),
 });