Skip to content

Commit 0d1e0aa

Browse files
authored
test: remove duplicate cases (#927)
1 parent e38ff8c commit 0d1e0aa

7 files changed

+0
-145
lines changed

tests/create-testing-library-rule.test.ts

-1
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,6 @@ ruleTester.run(RULE_NAME, rule, {
196196

197197
// cases: weird scenarios to check guard against parent nodes
198198
'expect(element).not()',
199-
'expect(element).not()',
200199

201200
// Test Cases for Queries and Aggressive Queries Reporting
202201
{

tests/lib/rules/no-await-sync-events.test.ts

-45
Original file line numberDiff line numberDiff line change
@@ -289,51 +289,6 @@ ruleTester.run(RULE_NAME, rule, {
289289
} as const)
290290
),
291291

292-
// sync fireEvent methods with await operator are not valid
293-
// when only fire-event set in eventModules
294-
...SUPPORTED_TESTING_FRAMEWORKS.flatMap((testingFramework) =>
295-
FIRE_EVENT_FUNCTIONS.map(
296-
(func) =>
297-
({
298-
code: `
299-
import { fireEvent } from '${testingFramework}';
300-
test('should report fireEvent.${func} sync event awaited', async() => {
301-
await fireEvent.${func}('foo');
302-
});
303-
`,
304-
errors: [
305-
{
306-
line: 4,
307-
column: 17,
308-
messageId: 'noAwaitSyncEvents',
309-
data: { name: `fireEvent.${func}` },
310-
},
311-
],
312-
} as const)
313-
)
314-
),
315-
316-
...USER_EVENT_SYNC_FUNCTIONS.map(
317-
(func) =>
318-
({
319-
code: `
320-
import userEvent from '@testing-library/user-event';
321-
test('should report userEvent.${func} sync event awaited', async() => {
322-
await userEvent.${func}('foo');
323-
});
324-
`,
325-
options: [{ eventModules: ['user-event'] }],
326-
errors: [
327-
{
328-
line: 4,
329-
column: 17,
330-
messageId: 'noAwaitSyncEvents',
331-
data: { name: `userEvent.${func}` },
332-
},
333-
],
334-
} as const)
335-
),
336-
337292
{
338293
code: `
339294
import userEvent from '@testing-library/user-event';

tests/lib/rules/no-debugging-utils.test.ts

-39
Original file line numberDiff line numberDiff line change
@@ -434,19 +434,6 @@ ruleTester.run(RULE_NAME, rule, {
434434
code: `
435435
import { screen } from '@testing-library/dom'
436436
screen.debug()
437-
`,
438-
errors: [
439-
{
440-
line: 3,
441-
column: 16,
442-
messageId: 'noDebug',
443-
},
444-
],
445-
},
446-
{
447-
code: `
448-
import { screen } from '@testing-library/dom'
449-
screen.logTestingPlaygroundURL()
450437
`,
451438
errors: [
452439
{
@@ -486,19 +473,6 @@ ruleTester.run(RULE_NAME, rule, {
486473
code: `
487474
import { screen } from '@testing-library/dom'
488475
screen.logTestingPlaygroundURL()
489-
`,
490-
errors: [
491-
{
492-
line: 3,
493-
column: 16,
494-
messageId: 'noDebug',
495-
},
496-
],
497-
},
498-
{
499-
code: `
500-
import { screen } from '@testing-library/dom'
501-
screen.logTestingPlaygroundURL()
502476
`,
503477
options: [{ utilsToCheckFor: {} }],
504478
errors: [
@@ -509,19 +483,6 @@ ruleTester.run(RULE_NAME, rule, {
509483
},
510484
],
511485
},
512-
{
513-
code: `
514-
import { screen } from '@testing-library/dom'
515-
screen.logTestingPlaygroundURL()
516-
`,
517-
errors: [
518-
{
519-
line: 3,
520-
column: 16,
521-
messageId: 'noDebug',
522-
},
523-
],
524-
},
525486
{
526487
settings: { 'testing-library/utils-module': 'test-utils' },
527488
code: `// aggressive reporting disabled

tests/lib/rules/no-wait-for-side-effects.test.ts

-18
Original file line numberDiff line numberDiff line change
@@ -299,16 +299,6 @@ ruleTester.run(RULE_NAME, rule, {
299299
settings: { 'testing-library/custom-renders': ['renderHelper'] },
300300
code: `
301301
import { waitFor } from '${testingFramework}';
302-
import { renderWrapper } from 'somewhere-else';
303-
await waitFor(() => {
304-
renderWrapper(<App />)
305-
})
306-
`,
307-
},
308-
{
309-
settings: { 'testing-library/custom-renders': ['renderHelper'] },
310-
code: `
311-
import { waitFor } from '${testingFramework}';
312302
await waitFor(() => result = renderWrapper(<App />))
313303
`,
314304
},
@@ -432,14 +422,6 @@ ruleTester.run(RULE_NAME, rule, {
432422
{
433423
code: `
434424
import { waitFor } from '${testingFramework}';
435-
const { rerender } = render(<App />)
436-
await waitFor(() => rerender(<App />))
437-
`,
438-
errors: [{ line: 4, column: 29, messageId: 'noSideEffectsWaitFor' }],
439-
} as const,
440-
{
441-
code: `
442-
import { waitFor } from '${testingFramework}';
443425
await waitFor(() => renderHelper(<App />))
444426
`,
445427
errors: [{ line: 3, column: 29, messageId: 'noSideEffectsWaitFor' }],

tests/lib/rules/prefer-explicit-assert.test.ts

-8
Original file line numberDiff line numberDiff line change
@@ -330,14 +330,6 @@ ruleTester.run(RULE_NAME, rule, {
330330
],
331331
} as const)
332332
),
333-
{
334-
code: `getByIcon('foo')`, // custom `getBy` query extended through options
335-
errors: [
336-
{
337-
messageId: 'preferExplicitAssert',
338-
},
339-
],
340-
},
341333
...COMBINED_QUERIES_METHODS.map(
342334
(queryMethod) =>
343335
({

tests/lib/rules/prefer-query-by-disappearance.test.ts

-14
Original file line numberDiff line numberDiff line change
@@ -219,20 +219,6 @@ ruleTester.run(RULE_NAME, rule, {
219219
code: `
220220
import { screen, waitForElementToBeRemoved } from '${testingFramework}';
221221
222-
await waitForElementToBeRemoved(() => screen.getByText("hello"))
223-
`,
224-
errors: [
225-
{
226-
messageId: 'preferQueryByDisappearance',
227-
line: 4,
228-
column: 54,
229-
},
230-
],
231-
},
232-
{
233-
code: `
234-
import { screen, waitForElementToBeRemoved } from '@marko/testing-library';
235-
236222
await waitForElementToBeRemoved(() => screen.getByText("hello"))
237223
`,
238224
errors: [

tests/lib/rules/prefer-screen-queries.test.ts

-20
Original file line numberDiff line numberDiff line change
@@ -278,26 +278,6 @@ ruleTester.run(RULE_NAME, rule, {
278278
} as const)
279279
)
280280
),
281-
...ALL_QUERIES_COMBINATIONS.map(
282-
(queryMethod) =>
283-
({
284-
settings: { 'testing-library/utils-module': 'test-utils' },
285-
code: `
286-
import { render } from 'test-utils'
287-
const { ${queryMethod} } = render(foo)
288-
${queryMethod}()`,
289-
errors: [
290-
{
291-
line: 4,
292-
column: 9,
293-
messageId: 'preferScreenQueries',
294-
data: {
295-
name: queryMethod,
296-
},
297-
},
298-
],
299-
} as const)
300-
),
301281
...ALL_QUERIES_COMBINATIONS.map(
302282
(queryMethod) =>
303283
({

0 commit comments

Comments
 (0)