Skip to content

Commit 049fd5c

Browse files
committed
feat(prefer-presence-queries): add to all configs by default
BREAKING CHANGE: `prefer-presence-queries` is now enabled by default in all configs
1 parent e0a34ed commit 049fd5c

File tree

7 files changed

+13
-5
lines changed

7 files changed

+13
-5
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ To enable this configuration use the `extends` property in your
208208
| [`testing-library/no-wait-for-snapshot`](./docs/rules/no-wait-for-snapshot.md) | Ensures no snapshot is generated inside of a `waitFor` call | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
209209
| [`testing-library/prefer-explicit-assert`](./docs/rules/prefer-explicit-assert.md) | Suggest using explicit assertions rather than standalone queries | | |
210210
| [`testing-library/prefer-find-by`](./docs/rules/prefer-find-by.md) | Suggest using `find(All)By*` query instead of `waitFor` + `get(All)By*` to wait for elements | 🔧 | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
211-
| [`testing-library/prefer-presence-queries`](./docs/rules/prefer-presence-queries.md) | Ensure appropriate `get*`/`query*` queries are used with their respective matchers | | |
211+
| [`testing-library/prefer-presence-queries`](./docs/rules/prefer-presence-queries.md) | Ensure appropriate `get*`/`query*` queries are used with their respective matchers | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
212212
| [`testing-library/prefer-query-by-disappearance`](./docs/rules/prefer-query-by-disappearance.md) | Suggest using `queryBy*` queries when waiting for disappearance | | |
213213
| [`testing-library/prefer-screen-queries`](./docs/rules/prefer-screen-queries.md) | Suggest using `screen` while querying | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
214214
| [`testing-library/prefer-user-event`](./docs/rules/prefer-user-event.md) | Suggest using `userEvent` over `fireEvent` for simulating user interactions | | |

lib/configs/angular.ts

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ export = {
1919
'testing-library/no-wait-for-side-effects': 'error',
2020
'testing-library/no-wait-for-snapshot': 'error',
2121
'testing-library/prefer-find-by': 'error',
22+
'testing-library/prefer-presence-queries': 'error',
2223
'testing-library/prefer-screen-queries': 'error',
2324
'testing-library/render-result-naming-convention': 'error',
2425
},

lib/configs/dom.ts

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export = {
1414
'testing-library/no-wait-for-side-effects': 'error',
1515
'testing-library/no-wait-for-snapshot': 'error',
1616
'testing-library/prefer-find-by': 'error',
17+
'testing-library/prefer-presence-queries': 'error',
1718
'testing-library/prefer-screen-queries': 'error',
1819
},
1920
};

lib/configs/react.ts

+1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ export = {
2020
'testing-library/no-wait-for-side-effects': 'error',
2121
'testing-library/no-wait-for-snapshot': 'error',
2222
'testing-library/prefer-find-by': 'error',
23+
'testing-library/prefer-presence-queries': 'error',
2324
'testing-library/prefer-screen-queries': 'error',
2425
'testing-library/render-result-naming-convention': 'error',
2526
},

lib/configs/vue.ts

+1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ export = {
2020
'testing-library/no-wait-for-side-effects': 'error',
2121
'testing-library/no-wait-for-snapshot': 'error',
2222
'testing-library/prefer-find-by': 'error',
23+
'testing-library/prefer-presence-queries': 'error',
2324
'testing-library/prefer-screen-queries': 'error',
2425
'testing-library/render-result-naming-convention': 'error',
2526
},

lib/rules/prefer-presence-queries.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ export default createTestingLibraryRule<Options, MessageIds>({
1515
description:
1616
'Ensure appropriate `get*`/`query*` queries are used with their respective matchers',
1717
recommendedConfig: {
18-
dom: false,
19-
angular: false,
20-
react: false,
21-
vue: false,
18+
dom: 'error',
19+
angular: 'error',
20+
react: 'error',
21+
vue: 'error',
2222
},
2323
},
2424
messages: {

tests/__snapshots__/index.test.ts.snap

+4
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ Object {
2424
"testing-library/no-wait-for-side-effects": "error",
2525
"testing-library/no-wait-for-snapshot": "error",
2626
"testing-library/prefer-find-by": "error",
27+
"testing-library/prefer-presence-queries": "error",
2728
"testing-library/prefer-screen-queries": "error",
2829
"testing-library/render-result-naming-convention": "error",
2930
},
@@ -42,6 +43,7 @@ Object {
4243
"testing-library/no-wait-for-side-effects": "error",
4344
"testing-library/no-wait-for-snapshot": "error",
4445
"testing-library/prefer-find-by": "error",
46+
"testing-library/prefer-presence-queries": "error",
4547
"testing-library/prefer-screen-queries": "error",
4648
},
4749
},
@@ -73,6 +75,7 @@ Object {
7375
"testing-library/no-wait-for-side-effects": "error",
7476
"testing-library/no-wait-for-snapshot": "error",
7577
"testing-library/prefer-find-by": "error",
78+
"testing-library/prefer-presence-queries": "error",
7679
"testing-library/prefer-screen-queries": "error",
7780
"testing-library/render-result-naming-convention": "error",
7881
},
@@ -100,6 +103,7 @@ Object {
100103
"testing-library/no-wait-for-side-effects": "error",
101104
"testing-library/no-wait-for-snapshot": "error",
102105
"testing-library/prefer-find-by": "error",
106+
"testing-library/prefer-presence-queries": "error",
103107
"testing-library/prefer-screen-queries": "error",
104108
"testing-library/render-result-naming-convention": "error",
105109
},

0 commit comments

Comments
 (0)