-
Notifications
You must be signed in to change notification settings - Fork 147
/
Copy pathno-debug.ts
124 lines (111 loc) · 3.64 KB
/
no-debug.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
import {
getDeepestIdentifierNode,
getFunctionName,
getInnermostReturningFunction,
getPropertyIdentifierNode,
getReferenceNode,
isObjectPattern,
isProperty,
} from '../node-utils';
import { createTestingLibraryRule } from '../create-testing-library-rule';
import { ASTUtils, TSESTree } from '@typescript-eslint/experimental-utils';
export const RULE_NAME = 'no-debug';
export type MessageIds = 'noDebug';
type Options = [];
export default createTestingLibraryRule<Options, MessageIds>({
name: RULE_NAME,
meta: {
type: 'problem',
docs: {
description: 'Disallow unnecessary debug usages in the tests',
category: 'Best Practices',
recommended: 'warn',
},
messages: {
noDebug: 'Unexpected debug statement',
},
fixable: null,
schema: [
{
type: 'object',
properties: {
renderFunctions: {
type: 'array',
},
},
},
],
},
defaultOptions: [],
create(context, [], helpers) {
const suspiciousDebugVariableNames: string[] = [];
const suspiciousReferenceNodes: TSESTree.Identifier[] = [];
const renderWrapperNames: string[] = [];
function detectRenderWrapper(node: TSESTree.Identifier): void {
const innerFunction = getInnermostReturningFunction(context, node);
if (innerFunction) {
renderWrapperNames.push(getFunctionName(innerFunction));
}
}
return {
VariableDeclarator(node) {
const initIdentifierNode = getDeepestIdentifierNode(node.init);
const isRenderWrapperVariableDeclarator = initIdentifierNode
? renderWrapperNames.includes(initIdentifierNode.name)
: false;
if (
!helpers.isRenderVariableDeclarator(node) &&
!isRenderWrapperVariableDeclarator
) {
return;
}
// find debug obtained from render and save their name, like:
// const { debug } = render();
if (isObjectPattern(node.id)) {
for (const property of node.id.properties) {
if (
isProperty(property) &&
ASTUtils.isIdentifier(property.key) &&
property.key.name === 'debug'
) {
suspiciousDebugVariableNames.push(
getDeepestIdentifierNode(property.value).name
);
}
}
}
// find utils kept from render and save their node, like:
// const utils = render();
if (ASTUtils.isIdentifier(node.id)) {
suspiciousReferenceNodes.push(node.id);
}
},
CallExpression(node) {
const callExpressionIdentifier = getDeepestIdentifierNode(node);
if (helpers.isRenderUtil(callExpressionIdentifier)) {
detectRenderWrapper(callExpressionIdentifier);
}
const referenceNode = getReferenceNode(node);
const referenceIdentifier = getPropertyIdentifierNode(referenceNode);
const isDebugUtil = helpers.isDebugUtil(callExpressionIdentifier);
const isDeclaredDebugVariable = suspiciousDebugVariableNames.includes(
callExpressionIdentifier.name
);
const isChainedReferenceDebug = suspiciousReferenceNodes.some(
(suspiciousReferenceIdentifier) => {
return (
callExpressionIdentifier.name === 'debug' &&
suspiciousReferenceIdentifier.name === referenceIdentifier.name
);
}
);
if (isDebugUtil || isDeclaredDebugVariable || isChainedReferenceDebug) {
context.report({
node: callExpressionIdentifier,
messageId: 'noDebug',
});
}
},
};
},
});