-
Notifications
You must be signed in to change notification settings - Fork 147
/
Copy pathno-container.ts
145 lines (128 loc) · 4.31 KB
/
no-container.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
import { ASTUtils, TSESTree } from '@typescript-eslint/experimental-utils';
import {
getDeepestIdentifierNode,
getFunctionName,
getInnermostReturningFunction,
isMemberExpression,
isObjectPattern,
isProperty,
} from '../node-utils';
import { createTestingLibraryRule } from '../create-testing-library-rule';
export const RULE_NAME = 'no-container';
export type MessageIds = 'noContainer';
type Options = [];
export default createTestingLibraryRule<Options, MessageIds>({
name: RULE_NAME,
meta: {
type: 'problem',
docs: {
description: 'Disallow the use of container methods',
category: 'Best Practices',
recommended: 'error',
},
messages: {
noContainer:
'Avoid using container methods. Prefer using the methods from Testing Library, such as "getByRole()"',
},
fixable: null,
schema: [],
},
defaultOptions: [],
create(context, [], helpers) {
const destructuredContainerPropNames: string[] = [];
const renderWrapperNames: string[] = [];
let renderResultVarName: string = null;
let containerName: string = null;
let containerCallsMethod = false;
function detectRenderWrapper(node: TSESTree.Identifier): void {
const innerFunction = getInnermostReturningFunction(context, node);
if (innerFunction) {
renderWrapperNames.push(getFunctionName(innerFunction));
}
}
function showErrorIfChainedContainerMethod(
innerNode: TSESTree.MemberExpression
) {
if (isMemberExpression(innerNode)) {
if (ASTUtils.isIdentifier(innerNode.object)) {
const isContainerName = innerNode.object.name === containerName;
if (isContainerName) {
context.report({
node: innerNode,
messageId: 'noContainer',
});
return;
}
const isRenderWrapper = innerNode.object.name === renderResultVarName;
containerCallsMethod =
ASTUtils.isIdentifier(innerNode.property) &&
innerNode.property.name === 'container' &&
isRenderWrapper;
if (containerCallsMethod) {
context.report({
node: innerNode.property,
messageId: 'noContainer',
});
return;
}
}
showErrorIfChainedContainerMethod(
innerNode.object as TSESTree.MemberExpression
);
}
}
return {
CallExpression(node) {
const callExpressionIdentifier = getDeepestIdentifierNode(node);
if (helpers.isRenderUtil(callExpressionIdentifier)) {
detectRenderWrapper(callExpressionIdentifier);
}
if (isMemberExpression(node.callee)) {
showErrorIfChainedContainerMethod(node.callee);
} else {
ASTUtils.isIdentifier(node.callee) &&
destructuredContainerPropNames.includes(node.callee.name) &&
context.report({
node,
messageId: 'noContainer',
});
}
},
VariableDeclarator(node) {
const initIdentifierNode = getDeepestIdentifierNode(node.init);
const isRenderWrapperVariableDeclarator = initIdentifierNode
? renderWrapperNames.includes(initIdentifierNode.name)
: false;
if (
!helpers.isRenderVariableDeclarator(node) &&
!isRenderWrapperVariableDeclarator
) {
return;
}
if (isObjectPattern(node.id)) {
const containerIndex = node.id.properties.findIndex(
(property) =>
isProperty(property) &&
ASTUtils.isIdentifier(property.key) &&
property.key.name === 'container'
);
const nodeValue =
containerIndex !== -1 && node.id.properties[containerIndex].value;
if (ASTUtils.isIdentifier(nodeValue)) {
containerName = nodeValue.name;
} else {
isObjectPattern(nodeValue) &&
nodeValue.properties.forEach(
(property) =>
isProperty(property) &&
ASTUtils.isIdentifier(property.key) &&
destructuredContainerPropNames.push(property.key.name)
);
}
} else {
renderResultVarName = ASTUtils.isIdentifier(node.id) && node.id.name;
}
},
};
},
});