-
Notifications
You must be signed in to change notification settings - Fork 147
/
Copy pathprefer-query-by-disappearance.ts
182 lines (151 loc) · 4.55 KB
/
prefer-query-by-disappearance.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
import { TSESTree } from '@typescript-eslint/experimental-utils';
import { createTestingLibraryRule } from '../create-testing-library-rule';
import {
getPropertyIdentifierNode,
isArrowFunctionExpression,
isCallExpression,
isMemberExpression,
isFunctionExpression,
isExpressionStatement,
isReturnStatement,
isBlockStatement,
} from '../node-utils';
export const RULE_NAME = 'prefer-query-by-disappearance';
type MessageIds = 'preferQueryByDisappearance';
type Options = [];
export default createTestingLibraryRule<Options, MessageIds>({
name: RULE_NAME,
meta: {
type: 'problem',
docs: {
description:
'Suggest using `queryBy*` queries when waiting for disappearance',
recommendedConfig: {
dom: 'error',
angular: 'error',
react: 'error',
vue: 'error',
},
},
messages: {
preferQueryByDisappearance:
'Prefer using queryBy* when waiting for disappearance',
},
schema: [],
},
defaultOptions: [],
create(context, _, helpers) {
function isWaitForElementToBeRemoved(node: TSESTree.CallExpression) {
const identifierNode = getPropertyIdentifierNode(node);
if (!identifierNode) {
return false;
}
return helpers.isAsyncUtil(identifierNode, ['waitForElementToBeRemoved']);
}
function isReportableExpression(node: TSESTree.LeftHandSideExpression) {
const argumentProperty = isMemberExpression(node)
? getPropertyIdentifierNode(node.property)
: getPropertyIdentifierNode(node);
if (!argumentProperty) {
return false;
}
return (
helpers.isGetQueryVariant(argumentProperty) ||
helpers.isFindQueryVariant(argumentProperty)
);
}
function isNonCallbackViolation(node: TSESTree.CallExpressionArgument) {
if (!isCallExpression(node)) {
return false;
}
if (
!isMemberExpression(node.callee) &&
!getPropertyIdentifierNode(node.callee)
) {
return false;
}
return isReportableExpression(node.callee);
}
function isReturnViolation(node: TSESTree.Statement) {
if (!isReturnStatement(node) || !isCallExpression(node.argument)) {
return false;
}
return isReportableExpression(node.argument.callee);
}
function isNonReturnViolation(node: TSESTree.Statement) {
if (!isExpressionStatement(node) || !isCallExpression(node.expression)) {
return false;
}
if (
!isMemberExpression(node.expression.callee) &&
!getPropertyIdentifierNode(node.expression.callee)
) {
return false;
}
return isReportableExpression(node.expression.callee);
}
function isStatementViolation(statement: TSESTree.Statement) {
return isReturnViolation(statement) || isNonReturnViolation(statement);
}
function isFunctionExpressionViolation(
node: TSESTree.CallExpressionArgument
) {
if (!isFunctionExpression(node)) {
return false;
}
return node.body.body.some((statement) =>
isStatementViolation(statement)
);
}
function isArrowFunctionBodyViolation(
node: TSESTree.CallExpressionArgument
) {
if (!isArrowFunctionExpression(node) || !isBlockStatement(node.body)) {
return false;
}
return node.body.body.some((statement) =>
isStatementViolation(statement)
);
}
function isArrowFunctionImplicitReturnViolation(
node: TSESTree.CallExpressionArgument
) {
if (!isArrowFunctionExpression(node) || !isCallExpression(node.body)) {
return false;
}
if (
!isMemberExpression(node.body.callee) &&
!getPropertyIdentifierNode(node.body.callee)
) {
return false;
}
return isReportableExpression(node.body.callee);
}
function isArrowFunctionViolation(node: TSESTree.CallExpressionArgument) {
return (
isArrowFunctionBodyViolation(node) ||
isArrowFunctionImplicitReturnViolation(node)
);
}
function check(node: TSESTree.CallExpression) {
if (!isWaitForElementToBeRemoved(node)) {
return;
}
const argumentNode = node.arguments[0];
if (
!isNonCallbackViolation(argumentNode) &&
!isArrowFunctionViolation(argumentNode) &&
!isFunctionExpressionViolation(argumentNode)
) {
return;
}
context.report({
node: argumentNode,
messageId: 'preferQueryByDisappearance',
});
}
return {
CallExpression: check,
};
},
});