-
Notifications
You must be signed in to change notification settings - Fork 147
/
Copy pathno-await-sync-query.test.ts
218 lines (206 loc) · 5.6 KB
/
no-await-sync-query.test.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
import { createRuleTester } from '../test-utils';
import rule, { RULE_NAME } from '../../../lib/rules/no-await-sync-query';
import {
SYNC_QUERIES_COMBINATIONS,
ASYNC_QUERIES_COMBINATIONS,
} from '../../../lib/utils';
const ruleTester = createRuleTester();
ruleTester.run(RULE_NAME, rule, {
valid: [
// sync queries without await are valid
...SYNC_QUERIES_COMBINATIONS.map((query) => ({
code: `() => {
const element = ${query}('foo')
}
`,
})),
// custom sync queries without await are valid
`() => {
const element = getByIcon('search')
}
`,
`() => {
const element = queryByIcon('search')
}
`,
`() => {
const element = getAllByIcon('search')
}
`,
`() => {
const element = queryAllByIcon('search')
}
`,
// sync queries without await inside assert are valid
...SYNC_QUERIES_COMBINATIONS.map((query) => ({
code: `() => {
expect(${query}('foo')).toBeEnabled()
}
`,
})),
// async queries with await operator are valid
...ASYNC_QUERIES_COMBINATIONS.map((query) => ({
code: `async () => {
const element = await ${query}('foo')
}
`,
})),
// async queries with then method are valid
...ASYNC_QUERIES_COMBINATIONS.map((query) => ({
code: `() => {
${query}('foo').then(() => {});
}
`,
})),
// sync query awaited but not related to custom module is invalid but not reported
{
settings: { 'testing-library/module': 'test-utils' },
code: `
import { screen } from 'somewhere-else'
() => {
const element = await screen.getByRole('button')
}
`,
},
// sync query awaited but not matching filename pattern is invalid but not reported
{
settings: { 'testing-library/filename-pattern': '^.*\\.(nope)\\.js$' },
code: `
() => {
const element = await getByRole('button')
}
`,
},
// https://github.com/testing-library/eslint-plugin-testing-library/issues/276
`
// sync query within call expression but not part of the callee
const chooseElementFromSomewhere = async (text, getAllByLabelText) => {
const someElement = getAllByLabelText(text)[0].parentElement;
// ...
await someOtherAsyncFunction();
};
await chooseElementFromSomewhere('someTextToUseInAQuery', getAllByLabelText);
`,
`// edge case for coverage:
// valid use case without call expression
// so there is no innermost function scope found
await test('edge case for no innermost function scope', () => {
const foo = getAllByLabelText
})
`,
],
invalid: [
// sync queries with await operator are not valid
...SYNC_QUERIES_COMBINATIONS.map((query) => ({
code: `async () => {
const element = await ${query}('foo')
}
`,
errors: [
{
messageId: 'noAwaitSyncQuery',
line: 2,
column: 31,
},
],
})),
// custom sync queries with await operator are not valid
{
code: `
async () => {
const element = await getByIcon('search')
}
`,
errors: [{ messageId: 'noAwaitSyncQuery', line: 3, column: 31 }],
},
{
code: `
async () => {
const element = await queryByIcon('search')
}
`,
errors: [{ messageId: 'noAwaitSyncQuery', line: 3, column: 31 }],
},
{
code: `
async () => {
const element = await screen.getAllByIcon('search')
}
`,
errors: [{ messageId: 'noAwaitSyncQuery', line: 3, column: 38 }],
},
{
code: `
async () => {
const element = await screen.queryAllByIcon('search')
}
`,
errors: [{ messageId: 'noAwaitSyncQuery', line: 3, column: 38 }],
},
// sync queries with await operator inside assert are not valid
...SYNC_QUERIES_COMBINATIONS.map((query) => ({
code: `async () => {
expect(await ${query}('foo')).toBeEnabled()
}
`,
errors: [
{
messageId: 'noAwaitSyncQuery',
line: 2,
column: 22,
},
],
})),
// sync queries in screen with await operator are not valid
...SYNC_QUERIES_COMBINATIONS.map((query) => ({
code: `async () => {
const element = await screen.${query}('foo')
}
`,
errors: [
{
messageId: 'noAwaitSyncQuery',
line: 2,
column: 38,
},
],
})),
// sync queries in screen with await operator inside assert are not valid
...SYNC_QUERIES_COMBINATIONS.map((query) => ({
code: `async () => {
expect(await screen.${query}('foo')).toBeEnabled()
}
`,
errors: [
{
messageId: 'noAwaitSyncQuery',
line: 2,
column: 29,
},
],
})),
// sync query awaited and related to testing library module
// with custom module setting is not valid
{
settings: { 'testing-library/module': 'test-utils' },
code: `
import { screen } from '@testing-library/react'
() => {
const element = await screen.getByRole('button')
}
`,
errors: [{ messageId: 'noAwaitSyncQuery', line: 4, column: 38 }],
},
// sync query awaited and related to custom module is not valid
{
settings: { 'testing-library/module': 'test-utils' },
code: `
import { screen } from 'test-utils'
() => {
const element = await screen.getByRole('button')
}
`,
errors: [{ messageId: 'noAwaitSyncQuery', line: 4, column: 38 }],
},
],
});