-
Notifications
You must be signed in to change notification settings - Fork 147
/
Copy pathawait-async-query.ts
104 lines (94 loc) · 3.14 KB
/
await-async-query.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
import { ASTUtils, TSESTree } from '@typescript-eslint/experimental-utils';
import {
findClosestCallExpressionNode,
getFunctionName,
getInnermostReturningFunction,
getVariableReferences,
isPromiseHandled,
} from '../node-utils';
import { createTestingLibraryRule } from '../create-testing-library-rule';
export const RULE_NAME = 'await-async-query';
export type MessageIds = 'awaitAsyncQuery' | 'asyncQueryWrapper';
type Options = [];
export default createTestingLibraryRule<Options, MessageIds>({
name: RULE_NAME,
meta: {
type: 'problem',
docs: {
description: 'Enforce promises from async queries to be handled',
category: 'Best Practices',
recommended: 'warn',
},
messages: {
awaitAsyncQuery: 'promise returned from {{ name }} query must be handled',
asyncQueryWrapper:
'promise returned from {{ name }} wrapper over async query must be handled',
},
fixable: null,
schema: [],
},
defaultOptions: [],
create(context, _, helpers) {
const functionWrappersNames: string[] = [];
function detectAsyncQueryWrapper(node: TSESTree.Identifier) {
const innerFunction = getInnermostReturningFunction(context, node);
if (innerFunction) {
functionWrappersNames.push(getFunctionName(innerFunction));
}
}
return {
'CallExpression Identifier'(node: TSESTree.Identifier) {
if (helpers.isAsyncQuery(node)) {
// detect async query used within wrapper function for later analysis
detectAsyncQueryWrapper(node);
const closestCallExpressionNode = findClosestCallExpressionNode(
node,
true
);
if (!closestCallExpressionNode) {
return;
}
const references = getVariableReferences(
context,
closestCallExpressionNode.parent
);
// check direct usage of async query:
// const element = await findByRole('button')
if (references && references.length === 0) {
if (!isPromiseHandled(node)) {
return context.report({
node,
messageId: 'awaitAsyncQuery',
data: { name: node.name },
});
}
}
// check references usages of async query:
// const promise = findByRole('button')
// const element = await promise
for (const reference of references) {
if (
ASTUtils.isIdentifier(reference.identifier) &&
!isPromiseHandled(reference.identifier)
) {
return context.report({
node,
messageId: 'awaitAsyncQuery',
data: { name: node.name },
});
}
}
} else if (functionWrappersNames.includes(node.name)) {
// check async queries used within a wrapper previously detected
if (!isPromiseHandled(node)) {
return context.report({
node,
messageId: 'asyncQueryWrapper',
data: { name: node.name },
});
}
}
},
};
},
});