more async support

Author: benmonro

src/__tests__/lib/rules/prefer-in-document.js

@@ -49,7 +49,7 @@ const valid = [
 ];
 const invalid = [
   // Invalid cases that applies to all variants
-  ...["getByText", "getByRole"].map((q) => [
+  ...["getByText", "getAllByRole"].map((q) => [
     invalidCase(
       `expect(screen.${q}('foo')).toHaveLength(1)`,
       `expect(screen.${q}('foo')).toBeInTheDocument()`
@@ -92,7 +92,7 @@ const invalid = [
     ),
   ]),
   // Invalid cases that applies to queryBy* and queryAllBy*
-  ...["queryByText"].map((q) => [
+  ...["queryByText", "queryAllByText"].map((q) => [
     invalidCase(
       `expect(${q}('foo')).toHaveLength(0)`,
       `expect(${q}('foo')).not.toBeInTheDocument()`
@@ -148,6 +148,14 @@ const invalid = [
       expect(await findByRole("button")).toBeInTheDocument();
     })`
   ),
+  invalidCase(
+    `it("foo", async () => {
+      expect(await findByRole("button")).not.toBeNull();
+    })`,
+    `it("foo", async () => {
+      expect(await findByRole("button")).toBeInTheDocument();
+    })`
+  ),
   invalidCase(
     `it("foo", async () => {
       expect(await screen.findByText(/Compressing video/)).toBeDefined();
@@ -156,6 +164,14 @@ const invalid = [
       expect(await screen.findByText(/Compressing video/)).toBeInTheDocument();
     })`
   ),
+  invalidCase(
+    `it("foo", async () => {
+      expect(await screen.findByText(/Compressing video/)).not.toBeDefined();
+    })`,
+    `it("foo", async () => {
+      expect(await screen.findByText(/Compressing video/)).not.toBeInTheDocument();
+    })`
+  ),
   invalidCase(
     `it("foo", async () => {
       const compressingFeedback = await screen.findByText(/Compressing video/);
@@ -166,6 +182,16 @@ const invalid = [
       expect(compressingFeedback).toBeInTheDocument();
     });`
   ),
+  invalidCase(
+    `it("foo", async () => {
+      const compressingFeedback = await screen.findByText(/Compressing video/);
+      expect(compressingFeedback).not.toBeNull();
+    });`,
+    `it("foo", async () => {
+      const compressingFeedback = await screen.findByText(/Compressing video/);
+      expect(compressingFeedback).toBeInTheDocument();
+    });`
+  ),
   invalidCase(
     `it("foo", async () => {
       let compressingFeedback;
@@ -178,6 +204,18 @@ const invalid = [
       expect(compressingFeedback).toBeInTheDocument();
     });`
   ),
+  invalidCase(
+    `it("foo", async () => {
+      let compressingFeedback;
+      compressingFeedback = await screen.findByText(/Compressing video/);
+      expect(compressingFeedback).not.toBeDefined();
+    });`,
+    `it("foo", async () => {
+      let compressingFeedback;
+      compressingFeedback = await screen.findByText(/Compressing video/);
+      expect(compressingFeedback).not.toBeInTheDocument();
+    });`
+  ),
 ];
 
 const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2017 } });

src/rules/prefer-in-document.js

@@ -109,10 +109,12 @@ export const create = (context) => {
   }
   return {
     // expect(<query>).not.<matcher>
-    [`CallExpression[callee.object.object.callee.name='expect'][callee.object.property.name='not'][callee.property.name=${alternativeMatchers}]`](
+    [`CallExpression[callee.object.object.callee.name='expect'][callee.object.property.name='not'][callee.property.name=${alternativeMatchers}], CallExpression[callee.object.callee.name='expect'][callee.object.property.name='not'][callee.object.arguments.0.argument.callee.name=${alternativeMatchers}]`](
       node
     ) {
-      const queryNode = node.callee.object.object.arguments[0].callee;
+      const arg = node.callee.object.object.arguments[0];
+      const queryNode =
+        arg.type === "AwaitExpression" ? arg.argument.callee : arg.callee;
       const matcherNode = node.callee.property;
       const matcherArguments = node.arguments;