From 6e658fb802ab0a7761042643b9361562b2a93189 Mon Sep 17 00:00:00 2001 From: eps1lon Date: Sat, 11 Sep 2021 10:32:28 +0200 Subject: [PATCH 1/3] ensure we install past ^16.9.1? --- .github/workflows/validate.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml index e12e9f98..74d61d74 100644 --- a/.github/workflows/validate.yml +++ b/.github/workflows/validate.yml @@ -18,7 +18,7 @@ jobs: # Otherwise we would not know if the problem is tied to the Node.js version fail-fast: false matrix: - node: [12, 14, 16] + node: [12, 14, '^16.9.1'] runs-on: ubuntu-latest steps: - name: 🛑 Cancel Previous Runs From 4131f81249ab906becda4fd2fccf53320a364eca Mon Sep 17 00:00:00 2001 From: eps1lon Date: Sat, 11 Sep 2021 10:38:31 +0200 Subject: [PATCH 2/3] Does this work for codecov --- .github/workflows/validate.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml index 74d61d74..37783fae 100644 --- a/.github/workflows/validate.yml +++ b/.github/workflows/validate.yml @@ -18,7 +18,7 @@ jobs: # Otherwise we would not know if the problem is tied to the Node.js version fail-fast: false matrix: - node: [12, 14, '^16.9.1'] + node: [12, 14, '16.9.1'] runs-on: ubuntu-latest steps: - name: 🛑 Cancel Previous Runs From 135f09dd9ab7323856782a16ddfece27471bf9f8 Mon Sep 17 00:00:00 2001 From: eps1lon Date: Sat, 11 Sep 2021 10:39:43 +0200 Subject: [PATCH 3/3] codecov doesn't like the caret --- .github/workflows/validate.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml index 37783fae..fd803882 100644 --- a/.github/workflows/validate.yml +++ b/.github/workflows/validate.yml @@ -18,6 +18,7 @@ jobs: # Otherwise we would not know if the problem is tied to the Node.js version fail-fast: false matrix: + # TODO: relax `'16.9.1'` to `16` once GitHub has 16.9.1 cached. 16.9.0 is broken due to https://github.com/nodejs/node/issues/40030 node: [12, 14, '16.9.1'] runs-on: ubuntu-latest steps: