fix(ByLabel): use getNodeText abstraction instead of textContent

Closes #190

Author: Kent C. Dodds

src/get-node-text.js

@@ -2,7 +2,7 @@ function getNodeText(node) {
   const window = node.ownerDocument.defaultView
 
   if (node.matches('input[type=submit], input[type=button]')) {
-    return node.value;
+    return node.value
   }
 
   return Array.from(node.childNodes)

src/queries.js

@@ -21,7 +21,7 @@ function queryAllLabelsByText(
   const matcher = exact ? matches : fuzzyMatches
   const matchNormalizer = makeNormalizer({collapseWhitespace, trim, normalizer})
   return Array.from(container.querySelectorAll('label')).filter(label =>
-    matcher(label.textContent, label, text, matchNormalizer),
+    matcher(getNodeText(label), label, text, matchNormalizer),
   )
 }
 

src/wait-for-element.js

@@ -22,7 +22,7 @@ function waitForElement(
     const observer = newMutationObserver(onMutation)
     observer.observe(container, mutationObserverOptions)
     function onDone(error, result) {
-      const setImmediate = getSetImmediate();
+      const setImmediate = getSetImmediate()
       clearTimeout(timer)
       setImmediate(() => observer.disconnect())
       if (error) {

typings/get-queries-for-element.d.ts

@@ -9,8 +9,8 @@ export type BoundFunction<T> = T extends (
 ) => infer R
   ? (text: P, options?: Q) => R
   : T extends (a1: any, text: infer P, options: infer Q) => infer R
-    ? (text: P, options?: Q) => R
-    : never
+  ? (text: P, options?: Q) => R
+  : never
 export type BoundFunctions<T> = {[P in keyof T]: BoundFunction<T[P]>}
 
 export function getQueriesForElement(