fix: Disconnect MutationObserver synchronously in wait-for (#801)

romain-trotard · kentcdodds · web-flow · commit 2cb8405736ca · 2020-11-02T20:15:31.000-07:00
* Disconnect MutationObserver synchronously in wait-for

* Revert the pre-commit change to be able to commit

* Remove legacy disconnect

Co-authored-by: Kent C. Dodds &lt;me+github@kentcdodds.com&gt;
diff --git a/src/wait-for.js b/src/wait-for.js
@@ -94,7 +94,7 @@ function waitFor(
 
       if (!usingFakeTimers) {
         clearInterval(intervalId)
-        setImmediate(() => observer.disconnect())
+        observer.disconnect()
       }
 
       if (error) {

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ function waitFor(`
`94`	`94`
`95`	`95`	`if (!usingFakeTimers) {`
`96`	`96`	`clearInterval(intervalId)`
`97`		`- setImmediate(() => observer.disconnect())`
	`97`	`+ observer.disconnect()`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`if (error) {`