From 14464cc33cabde9b859aab8f86ac1d09989806ac Mon Sep 17 00:00:00 2001
From: Nick McCurdy <nick@nickmccurdy.com>
Date: Fri, 20 Nov 2020 17:28:01 -0500
Subject: [PATCH 1/2] fix(types): allow all elements

---
 types/index.d.ts |  2 +-
 types/test.ts    | 32 ++++++++++++++++----------------
 2 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/types/index.d.ts b/types/index.d.ts
index 1ad877a..7b954bb 100644
--- a/types/index.d.ts
+++ b/types/index.d.ts
@@ -10,7 +10,7 @@ import {
 
 export interface CTLMatcherOptions {
   timeout?: number
-  container?: HTMLElement | JQuery
+  container?: Element | JQuery<Element>
 }
 
 export type MatcherOptions = DTLMatcherOptions | CTLMatcherOptions
diff --git a/types/test.ts b/types/test.ts
index 28f3bf9..51f8374 100644
--- a/types/test.ts
+++ b/types/test.ts
@@ -5,24 +5,24 @@ import '@testing-library/cypress/add-commands'
 configure({testIdAttribute: 'data-myown-testid'})
 
 // findBy*
-cy.findByPlaceholderText('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
-cy.findByText('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
-cy.findByLabelText('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
-cy.findByAltText('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
-cy.findByTestId('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
-cy.findByTitle('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
-cy.findByDisplayValue('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
-cy.findByRole('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
+cy.findByPlaceholderText('foo') // $ExpectType Chainable<JQuery<Element>>
+cy.findByText('foo') // $ExpectType Chainable<JQuery<Element>>
+cy.findByLabelText('foo') // $ExpectType Chainable<JQuery<Element>>
+cy.findByAltText('foo') // $ExpectType Chainable<JQuery<Element>>
+cy.findByTestId('foo') // $ExpectType Chainable<JQuery<Element>>
+cy.findByTitle('foo') // $ExpectType Chainable<JQuery<Element>>
+cy.findByDisplayValue('foo') // $ExpectType Chainable<JQuery<Element>>
+cy.findByRole('foo') // $ExpectType Chainable<JQuery<Element>>
 
 // findAllBy*
-cy.findAllByPlaceholderText('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
-cy.findAllByText('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
-cy.findAllByLabelText('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
-cy.findAllByAltText('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
-cy.findAllByTestId('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
-cy.findAllByTitle('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
-cy.findAllByDisplayValue('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
-cy.findAllByRole('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
+cy.findAllByPlaceholderText('foo') // $ExpectType Chainable<JQuery<Element>>
+cy.findAllByText('foo') // $ExpectType Chainable<JQuery<Element>>
+cy.findAllByLabelText('foo') // $ExpectType Chainable<JQuery<Element>>
+cy.findAllByAltText('foo') // $ExpectType Chainable<JQuery<Element>>
+cy.findAllByTestId('foo') // $ExpectType Chainable<JQuery<Element>>
+cy.findAllByTitle('foo') // $ExpectType Chainable<JQuery<Element>>
+cy.findAllByDisplayValue('foo') // $ExpectType Chainable<JQuery<Element>>
+cy.findAllByRole('foo') // $ExpectType Chainable<JQuery<Element>>
 
 // configure
 cy.configureCypressTestingLibrary({testIdAttribute: 'data-myawesome-testid'}) // $ExpectType Chainable<void>

From 2739a2d4b4a3ee59942f1b06f170a39df3dcc2be Mon Sep 17 00:00:00 2001
From: Nick McCurdy <nick@nickmccurdy.com>
Date: Tue, 15 Dec 2020 03:52:56 -0500
Subject: [PATCH 2/2] chore: fix incorrect type test

---
 types/test.ts | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/types/test.ts b/types/test.ts
index 51f8374..28f3bf9 100644
--- a/types/test.ts
+++ b/types/test.ts
@@ -5,24 +5,24 @@ import '@testing-library/cypress/add-commands'
 configure({testIdAttribute: 'data-myown-testid'})
 
 // findBy*
-cy.findByPlaceholderText('foo') // $ExpectType Chainable<JQuery<Element>>
-cy.findByText('foo') // $ExpectType Chainable<JQuery<Element>>
-cy.findByLabelText('foo') // $ExpectType Chainable<JQuery<Element>>
-cy.findByAltText('foo') // $ExpectType Chainable<JQuery<Element>>
-cy.findByTestId('foo') // $ExpectType Chainable<JQuery<Element>>
-cy.findByTitle('foo') // $ExpectType Chainable<JQuery<Element>>
-cy.findByDisplayValue('foo') // $ExpectType Chainable<JQuery<Element>>
-cy.findByRole('foo') // $ExpectType Chainable<JQuery<Element>>
+cy.findByPlaceholderText('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
+cy.findByText('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
+cy.findByLabelText('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
+cy.findByAltText('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
+cy.findByTestId('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
+cy.findByTitle('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
+cy.findByDisplayValue('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
+cy.findByRole('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
 
 // findAllBy*
-cy.findAllByPlaceholderText('foo') // $ExpectType Chainable<JQuery<Element>>
-cy.findAllByText('foo') // $ExpectType Chainable<JQuery<Element>>
-cy.findAllByLabelText('foo') // $ExpectType Chainable<JQuery<Element>>
-cy.findAllByAltText('foo') // $ExpectType Chainable<JQuery<Element>>
-cy.findAllByTestId('foo') // $ExpectType Chainable<JQuery<Element>>
-cy.findAllByTitle('foo') // $ExpectType Chainable<JQuery<Element>>
-cy.findAllByDisplayValue('foo') // $ExpectType Chainable<JQuery<Element>>
-cy.findAllByRole('foo') // $ExpectType Chainable<JQuery<Element>>
+cy.findAllByPlaceholderText('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
+cy.findAllByText('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
+cy.findAllByLabelText('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
+cy.findAllByAltText('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
+cy.findAllByTestId('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
+cy.findAllByTitle('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
+cy.findAllByDisplayValue('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
+cy.findAllByRole('foo') // $ExpectType Chainable<JQuery<HTMLElement>>
 
 // configure
 cy.configureCypressTestingLibrary({testIdAttribute: 'data-myawesome-testid'}) // $ExpectType Chainable<void>