From 1ac2d856ac5cc60ffb345b9716d2efa8a3108612 Mon Sep 17 00:00:00 2001
From: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
Date: Fri, 25 Feb 2022 20:05:49 +0100
Subject: [PATCH] test: refactor router test

---
 .../example-app/src/app/app-routing.module.ts |  4 +-
 apps/example-app/src/app/app.module.ts        |  4 +-
 .../src/app/examples/09-router.spec.ts        | 48 +++++++++++++++++--
 .../example-app/src/app/examples/09-router.ts |  2 +-
 4 files changed, 49 insertions(+), 9 deletions(-)

diff --git a/apps/example-app/src/app/app-routing.module.ts b/apps/example-app/src/app/app-routing.module.ts
index 1cfa2f59..a553ba61 100644
--- a/apps/example-app/src/app/app-routing.module.ts
+++ b/apps/example-app/src/app/app-routing.module.ts
@@ -9,7 +9,7 @@ import { MaterialFormsComponent } from './examples/04-forms-with-material';
 import { ComponentWithProviderComponent } from './examples/05-component-provider';
 import { WithNgRxStoreComponent } from './examples/06-with-ngrx-store';
 import { WithNgRxMockStoreComponent } from './examples/07-with-ngrx-mock-store';
-import { MasterComponent, DetailComponent, HiddenDetailComponent } from './examples/09-router';
+import { RootComponent, DetailComponent, HiddenDetailComponent } from './examples/09-router';
 
 export const examples = [
   {
@@ -70,7 +70,7 @@ export const examples = [
   },
   {
     path: 'with-router',
-    component: MasterComponent,
+    component: RootComponent,
     data: {
       name: 'Router',
     },
diff --git a/apps/example-app/src/app/app.module.ts b/apps/example-app/src/app/app.module.ts
index fb4ccaf7..cb95434f 100644
--- a/apps/example-app/src/app/app.module.ts
+++ b/apps/example-app/src/app/app.module.ts
@@ -20,7 +20,7 @@ import { MaterialFormsComponent } from './examples/04-forms-with-material';
 import { ComponentWithProviderComponent } from './examples/05-component-provider';
 import { WithNgRxStoreComponent, reducer } from './examples/06-with-ngrx-store';
 import { WithNgRxMockStoreComponent } from './examples/07-with-ngrx-mock-store';
-import { MasterComponent, DetailComponent, HiddenDetailComponent } from './examples/09-router';
+import { RootComponent, DetailComponent, HiddenDetailComponent } from './examples/09-router';
 import { ScrollingModule } from '@angular/cdk/scrolling';
 
 function reducerItems() {
@@ -40,7 +40,7 @@ function reducerItems() {
     ComponentWithProviderComponent,
     WithNgRxStoreComponent,
     WithNgRxMockStoreComponent,
-    MasterComponent,
+    RootComponent,
     DetailComponent,
     HiddenDetailComponent,
   ],
diff --git a/apps/example-app/src/app/examples/09-router.spec.ts b/apps/example-app/src/app/examples/09-router.spec.ts
index 16f037fc..1e2be51b 100644
--- a/apps/example-app/src/app/examples/09-router.spec.ts
+++ b/apps/example-app/src/app/examples/09-router.spec.ts
@@ -1,9 +1,49 @@
-import { render, screen } from '@testing-library/angular';
+import { render, screen, waitForElementToBeRemoved } from '@testing-library/angular';
+import userEvent from '@testing-library/user-event';
 
-import { DetailComponent, MasterComponent, HiddenDetailComponent } from './09-router';
+import { DetailComponent, RootComponent, HiddenDetailComponent } from './09-router';
 
 test('it can navigate to routes', async () => {
-  const { navigate } = await render(MasterComponent, {
+  await render(RootComponent, {
+    declarations: [DetailComponent, HiddenDetailComponent],
+    routes: [
+      {
+        path: '',
+        children: [
+          {
+            path: 'detail/:id',
+            component: DetailComponent,
+          },
+          {
+            path: 'hidden-detail',
+            component: HiddenDetailComponent,
+          },
+        ],
+      },
+    ],
+  });
+
+  expect(screen.queryByText(/Detail one/i)).not.toBeInTheDocument();
+
+  userEvent.click(screen.getByRole('link', { name: /load one/i }));
+  expect(await screen.findByRole('heading', { name: /Detail one/i })).toBeInTheDocument();
+
+  userEvent.click(screen.getByRole('link', { name: /load three/i }));
+  await waitForElementToBeRemoved(() => screen.queryByRole('heading', { name: /Detail one/i }));
+  expect(await screen.findByRole('heading', { name: /Detail three/i })).toBeInTheDocument();
+
+  userEvent.click(screen.getByRole('link', { name: /back to parent/i }));
+  await waitForElementToBeRemoved(() => screen.queryByRole('heading', { name: /Detail three/i }));
+
+  userEvent.click(screen.getByRole('link', { name: /load two/i }));
+  expect(await screen.findByRole('heading', { name: /Detail two/i })).toBeInTheDocument();
+
+  userEvent.click(screen.getByRole('link', { name: /hidden x/i }));
+  expect(await screen.findByText(/You found the treasure!/i)).toBeInTheDocument();
+});
+
+test('it can navigate to routes - workaround', async () => {
+  const { navigate } = await render(RootComponent, {
     declarations: [DetailComponent, HiddenDetailComponent],
     routes: [
       {
@@ -42,7 +82,7 @@ test('it can navigate to routes', async () => {
 
 test('it can navigate to routes with a base path', async () => {
   const basePath = 'base';
-  const { navigate } = await render(MasterComponent, {
+  const { navigate } = await render(RootComponent, {
     declarations: [DetailComponent, HiddenDetailComponent],
     routes: [
       {
diff --git a/apps/example-app/src/app/examples/09-router.ts b/apps/example-app/src/app/examples/09-router.ts
index 7d4e300d..6ea0df73 100644
--- a/apps/example-app/src/app/examples/09-router.ts
+++ b/apps/example-app/src/app/examples/09-router.ts
@@ -13,7 +13,7 @@ import { map } from 'rxjs/operators';
     <router-outlet></router-outlet>
   `,
 })
-export class MasterComponent {}
+export class RootComponent {}
 
 @Component({
   selector: 'app-detail',