Skip to content

feat: upgrade Angular 14 #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 9, 2022
Merged

feat: upgrade Angular 14 #297

merged 5 commits into from
Jun 9, 2022

Conversation

jadengis
Copy link
Contributor

@jadengis jadengis commented Jun 8, 2022

  • update @angular/core
  • update @angular/cli
  • updated @angular/material
  • fix standalone components

Closes #296

@jadengis
feat: upgrade Angular 14
45edf2f 
- update @angular/core
- update @angular/cli
- updated @angular/material
- fix standalone components
timdeschryver
timdeschryver reviewed Jun 8, 2022
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this PR!
I think a second test that uses standalone components that have a child component will be helpful as well.
Thoughts?

@jadengis
Copy link
Contributor Author

jadengis commented Jun 8, 2022

@timdeschryver I've added a test with a child component.

timdeschryver
timdeschryver approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

@timdeschryver
Copy link
Member

@all-contributors please add @jadengis for code, tests

@allcontributors allcontributors bot mentioned this pull request Jun 9, 2022
Merged
@allcontributors
Copy link
Contributor

@timdeschryver

I've put up a pull request to add @jadengis! 🎉

@timdeschryver timdeschryver merged commit 6b94d25 into testing-library:main Jun 9, 2022
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

🎉 This PR is included in version 12.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular 14 support
2 participants
@jadengis @timdeschryver