Skip to content

fix: rerender with template #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2021
Merged

fix: rerender with template #223

merged 2 commits into from
Jun 3, 2021

Conversation

rothsandro
Copy link
Contributor

Fixes #222

timdeschryver
timdeschryver approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rothsandro !

@timdeschryver timdeschryver merged commit dbd468f into testing-library:main Jun 3, 2021
@timdeschryver
Copy link
Member

@all-contributors please add @rothsandro for code, bug

@allcontributors allcontributors bot mentioned this pull request Jun 3, 2021
Merged
@allcontributors
Copy link
Contributor

@timdeschryver

I've put up a pull request to add @rothsandro! 🎉

@github-actions
Copy link

github-actions bot commented Jun 3, 2021

🎉 This PR is included in version 10.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rerender with template throws "Cannot redefine property"
2 participants
@rothsandro @timdeschryver