Skip to content

Commit ae9242d

Browse files
committed
fix DockerComposeContainer parameter
1 parent 9aec472 commit ae9242d

File tree

1 file changed

+19
-19
lines changed

1 file changed

+19
-19
lines changed

core/src/main/scala/com/dimafeng/testcontainers/DockerComposeContainer.scala

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,6 @@ import org.testcontainers.utility.Base58
1212

1313
import scala.collection.JavaConverters._
1414

15-
sealed trait Services
16-
object Services {
17-
case object All extends Services
18-
final case class Specific(services: Seq[Service]) extends Services
19-
}
20-
21-
final case class Service(name: String)
22-
2315
object ExposedService {
2416
def apply(name: String, port: Int, instance: Int, waitStrategy: WaitStrategy): ExposedService =
2517
ExposedService(name, port, waitStrategy, Option(instance))
@@ -36,6 +28,14 @@ final case class ServiceLogConsumer(serviceName: String, consumer: Consumer[Outp
3628

3729
final case class WaitingForService(serviceName: String, waitStrategy: WaitStrategy)
3830

31+
sealed trait Services
32+
object Services {
33+
case object All extends Services
34+
final case class Specific(services: Seq[Service]) extends Services
35+
}
36+
37+
final case class Service(name: String)
38+
3939
object DockerComposeContainer {
4040
val ID_LENGTH = 6
4141

@@ -60,10 +60,9 @@ object DockerComposeContainer {
6060
@deprecated("Please use expanded `apply` method")
6161
def apply(composeFiles: ComposeFile,
6262
exposedService: Map[String, Int]): DockerComposeContainer =
63-
new DockerComposeContainer(composeFiles, Services.All, exposedService)
63+
new DockerComposeContainer(composeFiles, exposedService)
6464

6565
def apply(composeFiles: ComposeFile,
66-
services: Services = Services.All,
6766
exposedServices: Seq[ExposedService] = Seq.empty,
6867
identifier: String = DockerComposeContainer.randomIdentifier,
6968
scaledServices: Seq[ScaledService] = Seq.empty,
@@ -72,9 +71,9 @@ object DockerComposeContainer {
7271
env: Map[String, String] = Map.empty,
7372
tailChildContainers: Boolean = false,
7473
logConsumers: Seq[ServiceLogConsumer] = Seq.empty,
75-
waitingFor: Option[WaitingForService] = None): DockerComposeContainer =
74+
waitingFor: Option[WaitingForService] = None,
75+
services: Services = Services.All): DockerComposeContainer =
7676
new DockerComposeContainer(composeFiles,
77-
services,
7877
exposedServices,
7978
identifier,
8079
scaledServices,
@@ -83,11 +82,11 @@ object DockerComposeContainer {
8382
env,
8483
tailChildContainers,
8584
logConsumers,
86-
waitingFor)
85+
waitingFor,
86+
services)
8787

8888
case class Def(
8989
composeFiles: ComposeFile,
90-
services: Services = Services.All,
9190
exposedServices: Seq[ExposedService] = Seq.empty,
9291
identifier: String = DockerComposeContainer.randomIdentifier,
9392
scaledServices: Seq[ScaledService] = Seq.empty,
@@ -96,15 +95,15 @@ object DockerComposeContainer {
9695
env: Map[String, String] = Map.empty,
9796
tailChildContainers: Boolean = false,
9897
logConsumers: Seq[ServiceLogConsumer] = Seq.empty,
99-
waitingFor: Option[WaitingForService] = None
98+
waitingFor: Option[WaitingForService] = None,
99+
services: Services = Services.All
100100
) extends ContainerDef {
101101

102102
override type Container = DockerComposeContainer
103103

104104
override def createContainer(): DockerComposeContainer = {
105105
DockerComposeContainer(
106106
composeFiles,
107-
services,
108107
exposedServices,
109108
identifier,
110109
scaledServices,
@@ -113,15 +112,15 @@ object DockerComposeContainer {
113112
env,
114113
tailChildContainers,
115114
logConsumers,
116-
waitingFor
115+
waitingFor,
116+
services
117117
)
118118
}
119119
}
120120

121121
}
122122

123123
class DockerComposeContainer(composeFiles: ComposeFile,
124-
services: Services = Services.All,
125124
exposedServices: Seq[ExposedService] = Seq.empty,
126125
identifier: String = DockerComposeContainer.randomIdentifier,
127126
scaledServices: Seq[ScaledService] = Seq.empty,
@@ -130,7 +129,8 @@ class DockerComposeContainer(composeFiles: ComposeFile,
130129
env: Map[String, String] = Map.empty,
131130
tailChildContainers: Boolean = false,
132131
logConsumers: Seq[ServiceLogConsumer] = Seq.empty,
133-
waitingFor: Option[WaitingForService] = None)
132+
waitingFor: Option[WaitingForService] = None,
133+
services: Services = Services.All)
134134
extends TestContainerProxy[JavaDockerComposeContainer[_]] {
135135

136136
override val container: JavaDockerComposeContainer[_] = {

0 commit comments

Comments
 (0)