Skip to content

Commit de74de3

Browse files
ci: changed from actions-rs to a more maintained CI alternative (#188)
In CI, we are currently using `actions-rs` variant of steps. [They are pretty deprecated.](https://github.com/actions-rs) This resolves these, which I noticed during #186's [actions run](https://github.com/testcontainers/testcontainers-rs-modules-community/actions/runs/10481678682?pr=186): ![image](https://github.com/user-attachments/assets/26f6a040-314e-4183-bec9-0b0a03701b32) There are a ton of options avaliable, maybe even a `rust-lang`-action rust-lang/rustup#3409 Currently, that is not the case. (open to alternatives if you prefer another one more ^^) > [!NOTE] > This is not without downside as replacing `uses: actions-rs/cargo` with `run: cargo ...` does not come with the annotations that github displays f. ex. here from another repo where I recently also contributed this: > ![image](https://github.com/user-attachments/assets/6b61c970-800d-4489-8433-bd5df44bc5fa) > Said annotation would still be shown, but only as a test failour and not inline.. I have also added the nightly rustfmt part ^^
1 parent 535e648 commit de74de3

File tree

1 file changed

+5
-18
lines changed

1 file changed

+5
-18
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -46,37 +46,24 @@ jobs:
4646
steps:
4747
- name: Checkout sources
4848
uses: actions/checkout@v4
49-
- uses: Swatinem/rust-cache@v2
50-
- uses: actions-rs/toolchain@v1
49+
- uses: actions-rust-lang/[email protected]
5150
with:
52-
profile: minimal
5351
toolchain: stable
5452
components: clippy
55-
override: true
5653
- name: Clippy check
57-
uses: actions-rs/clippy-check@v1
58-
with:
59-
token: ${{ secrets.GITHUB_TOKEN }}
60-
args: --all-features
54+
run: cargo clippy --all-features
6155

6256
fmt:
6357
name: Rustfmt check
6458
runs-on: ubuntu-latest
6559
steps:
6660
- name: Checkout sources
6761
uses: actions/checkout@v4
68-
- uses: Swatinem/rust-cache@v2
69-
- uses: actions-rs/toolchain@v1
62+
- uses: actions-rust-lang/[email protected]
7063
with:
71-
profile: minimal
72-
toolchain: stable
64+
toolchain: nightly
7365
components: rustfmt
74-
override: true
75-
- name: Rustfmt check
76-
uses: actions-rs/cargo@v1
77-
with:
78-
command: fmt
79-
args: --all -- --check
66+
- run: cargo +nightly fmt --all -- --check
8067

8168
prlint:
8269
name: PR name check

0 commit comments

Comments
 (0)