Skip to content

Commit b65f34f

Browse files
author
mikatong
committed
fix tco sync
1 parent c290d73 commit b65f34f

4 files changed

+24
-8
lines changed

tencentcloud/services/tco/resource_tc_identity_center_role_configuration_permission_policy_attachment.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ func ResourceTencentCloudIdentityCenterRoleConfigurationPermissionPolicyAttachme
4747

4848
"role_policy_name": {
4949
Type: schema.TypeString,
50+
Optional: true,
5051
Computed: true,
5152
Description: "Role policy name.",
5253
},
@@ -111,10 +112,14 @@ func resourceTencentCloudIdentityCenterRoleConfigurationPermissionPolicyAttachme
111112
request.RolePolicyType = helper.String("System")
112113

113114
if v, ok := d.GetOk("role_policy_id"); ok {
115+
policyDetail := &organization.PolicyDetail{
116+
PolicyId: helper.IntInt64(v.(int)),
117+
}
118+
if vv, innerOk := d.GetOk("role_policy_name"); innerOk {
119+
policyDetail.PolicyName = helper.String(vv.(string))
120+
}
114121
request.RolePolicies = []*organization.PolicyDetail{
115-
{
116-
PolicyId: helper.IntInt64(v.(int)),
117-
},
122+
policyDetail,
118123
}
119124
}
120125

tencentcloud/services/tco/resource_tc_identity_center_role_configuration_permission_policy_attachment_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ func TestAccTencentCloudIdentityCenterRoleConfigurationPermissionPolicyAttachmen
2020
Config: testAccIdentityCenterRoleConfigurationPermissionPolicyAttachment,
2121
Check: resource.ComposeTestCheckFunc(
2222
resource.TestCheckResourceAttrSet("tencentcloud_identity_center_role_configuration_permission_policy_attachment.identity_center_role_configuration_permission_policy_attachment", "id"),
23+
resource.TestCheckResourceAttrSet("tencentcloud_identity_center_role_configuration_permission_policy_attachment.identity_center_role_configuration_permission_policy_attachment", "role_policy_name"),
2324
),
2425
},
2526
{
@@ -42,5 +43,6 @@ resource "tencentcloud_identity_center_role_configuration_permission_policy_atta
4243
zone_id = "z-s64jh54hbcra"
4344
role_configuration_id = tencentcloud_identity_center_role_configuration.identity_center_role_configuration.role_configuration_id
4445
role_policy_id = 186457
46+
role_policy_name = "QcloudVPCReadOnlyAccess"
4547
}
4648
`

tencentcloud/services/tco/service_tencentcloud_organization.go

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1287,21 +1287,30 @@ func (me *OrganizationService) DescribeIdentityCenterUserById(ctx context.Contex
12871287
request := organization.NewGetUserRequest()
12881288
request.UserId = helper.String(userId)
12891289
request.ZoneId = helper.String(zoneId)
1290+
response := organization.NewGetUserResponse()
12901291

12911292
defer func() {
12921293
if errRet != nil {
12931294
log.Printf("[CRITAL]%s api[%s] fail, request body [%s], reason[%s]\n", logId, request.GetAction(), request.ToJsonString(), errRet.Error())
12941295
}
12951296
}()
12961297

1297-
ratelimit.Check(request.GetAction())
1298-
1299-
response, err := me.client.UseOrganizationClient().GetUser(request)
1298+
err := resource.Retry(tccommon.WriteRetryTimeout, func() *resource.RetryError {
1299+
ratelimit.Check(request.GetAction())
1300+
result, e := me.client.UseOrganizationClient().GetUser(request)
1301+
if e != nil {
1302+
return tccommon.RetryError(e)
1303+
} else {
1304+
log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n", logId, request.GetAction(), request.ToJsonString(), result.ToJsonString())
1305+
}
1306+
response = result
1307+
return nil
1308+
})
13001309
if err != nil {
13011310
errRet = err
1311+
log.Printf("[CRITAL]%s update identity center user failed, reason:%+v", logId, err)
13021312
return
13031313
}
1304-
log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n", logId, request.GetAction(), request.ToJsonString(), response.ToJsonString())
13051314

13061315
if response.Response == nil {
13071316
return

website/docs/r/identity_center_role_configuration_permission_policy_attachment.html.markdown

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ The following arguments are supported:
2828
* `role_configuration_id` - (Required, String, ForceNew) Permission configuration ID.
2929
* `role_policy_id` - (Required, Int, ForceNew) Role policy id.
3030
* `zone_id` - (Required, String, ForceNew) Space ID.
31+
* `role_policy_name` - (Optional, String) Role policy name.
3132

3233
## Attributes Reference
3334

@@ -36,7 +37,6 @@ In addition to all arguments above, the following attributes are exported:
3637
* `id` - ID of the resource.
3738
* `add_time` - Role policy add time.
3839
* `role_policy_document` - Role policy document.
39-
* `role_policy_name` - Role policy name.
4040
* `role_policy_type` - Role policy type.
4141

4242

0 commit comments

Comments
 (0)