Skip to content

Commit aece3c4

Browse files
tongyimingmikatong
and
mikatong
authored
fix(cbs): [123456789] backup quota (#3096)
* fix backup quota * add changelog * update --------- Co-authored-by: mikatong <[email protected]>
1 parent d56429e commit aece3c4

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

.changelog/3096.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:enhancement
2+
resource/tencentcloud_cbs_storage: fix `disk_backup_quota` update failed
3+
```

tencentcloud/services/cbs/resource_tc_cbs_storage.go

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -230,13 +230,6 @@ func resourceTencentCloudCbsStorageCreate(d *schema.ResourceData, meta interface
230230

231231
d.SetId(storageId)
232232

233-
if v, ok := d.GetOk("disk_backup_quota"); ok {
234-
err = cbsService.ModifyDiskBackupQuota(ctx, storageId, v.(int))
235-
if err != nil {
236-
return err
237-
}
238-
}
239-
240233
// must wait for finishing creating disk
241234
err = resource.Retry(10*tccommon.ReadRetryTimeout, func() *resource.RetryError {
242235
storage, e := cbsService.DescribeDiskById(ctx, storageId)
@@ -254,6 +247,12 @@ func resourceTencentCloudCbsStorageCreate(d *schema.ResourceData, meta interface
254247
if err != nil {
255248
return err
256249
}
250+
if v, ok := d.GetOk("disk_backup_quota"); ok {
251+
err = cbsService.ModifyDiskBackupQuota(ctx, storageId, v.(int))
252+
if err != nil {
253+
return err
254+
}
255+
}
257256

258257
return resourceTencentCloudCbsStorageRead(d, meta)
259258
}

tencentcloud/services/cbs/resource_tc_cbs_storage_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ func init() {
7878
}
7979

8080
func TestAccTencentCloudCbsStorageResource_basic(t *testing.T) {
81-
t.Parallel()
8281

8382
resource.Test(t, resource.TestCase{
8483
PreCheck: func() { tcacctest.AccPreCheck(t) },
@@ -106,7 +105,6 @@ func TestAccTencentCloudCbsStorageResource_basic(t *testing.T) {
106105
}
107106

108107
func TestAccTencentCloudCbsStorageResource_full(t *testing.T) {
109-
t.Parallel()
110108

111109
resource.Test(t, resource.TestCase{
112110
PreCheck: func() { tcacctest.AccPreCheck(t) },

0 commit comments

Comments
 (0)