fix(tag): [122090850] tencentcloud_tag optimize the creation retry logic (#3156)

* add

* add

Author: SevenEarth

.changelog/3156.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/tencentcloud_tag: optimize the creation retry logic
+```

tencentcloud/services/tag/resource_tc_tag.go

@@ -10,6 +10,7 @@ import (
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	sdkErrors "github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common/errors"
 	tag "github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/tag/v20180813"
 
 	"github.com/tencentcloudstack/terraform-provider-tencentcloud/tencentcloud/internal/helper"
@@ -28,14 +29,14 @@ func ResourceTencentCloudTag() *schema.Resource {
 				Required:    true,
 				ForceNew:    true,
 				Type:        schema.TypeString,
-				Description: "tag key.",
+				Description: "Tag key.",
 			},
 
 			"tag_value": {
 				Required:    true,
 				ForceNew:    true,
 				Type:        schema.TypeString,
-				Description: "tag value.",
+				Description: "Tag value.",
 			},
 		},
 	}
@@ -65,6 +66,12 @@ func resourceTencentCloudTagResourceCreate(d *schema.ResourceData, meta interfac
 	err := resource.Retry(tccommon.WriteRetryTimeout, func() *resource.RetryError {
 		result, e := meta.(tccommon.ProviderMeta).GetAPIV3Conn().UseTagClient().CreateTag(request)
 		if e != nil {
+			if sdkError, ok := e.(*sdkErrors.TencentCloudSDKError); ok {
+				if sdkError.Code == "ResourceInUse.TagDuplicate" {
+					return resource.NonRetryableError(e)
+				}
+			}
+
 			return tccommon.RetryError(e)
 		} else {
 			log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n", logId, request.GetAction(), request.ToJsonString(), result.ToJsonString())

tencentcloud/services/tag/resource_tc_tag.md

@@ -3,18 +3,16 @@ Provides a resource to create a tag
 Example Usage
 
 ```hcl
-
-resource "tencentcloud_tag" "tag" {
-	tag_key = "test"
-	tag_value = "Terraform"
+resource "tencentcloud_tag" "example" {
+  tag_key   = "tagKey"
+  tag_value = "tagValue"
 }
-
 ```
 
 Import
 
-tag tag can be imported using the id, e.g.
+tag can be imported using the id, e.g.
 
 ```
-terraform import tencentcloud_tag.tag tag_id
+terraform import tencentcloud_tag.example tagKey#tagValue
 ```

website/docs/r/tag.html.markdown

@@ -14,18 +14,18 @@ Provides a resource to create a tag
 ## Example Usage
 
 ```hcl
-resource "tencentcloud_tag" "tag" {
-  tag_key   = "test"
-  tag_value = "Terraform"
+resource "tencentcloud_tag" "example" {
+  tag_key   = "tagKey"
+  tag_value = "tagValue"
 }
 ```
 
 ## Argument Reference
 
 The following arguments are supported:
 
-* `tag_key` - (Required, String, ForceNew) tag key.
-* `tag_value` - (Required, String, ForceNew) tag value.
+* `tag_key` - (Required, String, ForceNew) Tag key.
+* `tag_value` - (Required, String, ForceNew) Tag value.
 
 ## Attributes Reference
 
@@ -37,9 +37,9 @@ In addition to all arguments above, the following attributes are exported:
 
 ## Import
 
-tag tag can be imported using the id, e.g.
+tag can be imported using the id, e.g.
 
 ```
-terraform import tencentcloud_tag.tag tag_id
+terraform import tencentcloud_tag.example tagKey#tagValue
 ```