support security group

Author: lyu571

.changelog/2866.txt

@@ -0,0 +1,7 @@
+```release-note:enhancement
+resource/tencentcloud_kubernetes_cluster_attachment: support param `taints` of worker_config
+```
+
+```release-note:enhancement
+resource/tencentcloud_kubernetes_cluster_attachment: support param `security_groups`
+```

tencentcloud/services/tke/resource_tc_kubernetes_cluster_attachment.go

@@ -425,8 +425,10 @@ func ResourceTencentCloudKubernetesClusterAttachment() *schema.Resource {
 			},
 
 			"security_groups": {
-				Type:        schema.TypeSet,
+				Type:        schema.TypeList,
 				Computed:    true,
+				Optional:    true,
+				ForceNew:    true,
 				Description: "A list of security group IDs after attach to cluster.",
 				Elem: &schema.Schema{
 					Type: schema.TypeString,
@@ -554,6 +556,14 @@ func resourceTencentCloudKubernetesClusterAttachmentCreate(d *schema.ResourceDat
 		request.HostName = helper.String(v.(string))
 	}
 
+	if v, ok := d.GetOk("security_groups"); ok {
+		securityGroupIdsSet := v.([]interface{})
+		for i := range securityGroupIdsSet {
+			securityGroupIds := securityGroupIdsSet[i].(string)
+			request.SecurityGroupIds = append(request.SecurityGroupIds, helper.String(securityGroupIds))
+		}
+	}
+
 	if v, ok := d.GetOk("worker_config_overrides"); ok {
 		for _, item := range v.([]interface{}) {
 			instanceAdvancedSettingsOverridesMap := item.(map[string]interface{})

tencentcloud/services/tke/resource_tc_kubernetes_cluster_attachment_extension.go

@@ -170,7 +170,7 @@ func resourceTencentCloudKubernetesClusterAttachmentReadRequestOnError2(ctx cont
 }
 
 func resourceTencentCloudKubernetesClusterAttachmentReadRequestOnSuccess2(ctx context.Context, resp *tke.Instance) *resource.RetryError {
-	d := tccommon.ResourceDataFromContext(ctx)
+	// d := tccommon.ResourceDataFromContext(ctx)
 	if resp == nil {
 		return nil
 	}
@@ -197,31 +197,32 @@ func resourceTencentCloudKubernetesClusterAttachmentReadRequestOnSuccess2(ctx co
 		))
 	}
 
-	if resp.InstanceAdvancedSettings.Taints != nil {
-		iAdvanced := resp.InstanceAdvancedSettings
-		taintsList := make([]map[string]interface{}, 0, len(iAdvanced.Taints))
-		if iAdvanced.Taints != nil {
-			for _, taints := range iAdvanced.Taints {
-				taintsMap := map[string]interface{}{}
+	// api cannot return Taints
+	// if resp.InstanceAdvancedSettings.Taints != nil {
+	// 	iAdvanced := resp.InstanceAdvancedSettings
+	// 	taintsList := make([]map[string]interface{}, 0, len(iAdvanced.Taints))
+	// 	if iAdvanced.Taints != nil {
+	// 		for _, taints := range iAdvanced.Taints {
+	// 			taintsMap := map[string]interface{}{}
 
-				if taints.Key != nil {
-					taintsMap["key"] = taints.Key
-				}
+	// 			if taints.Key != nil {
+	// 				taintsMap["key"] = taints.Key
+	// 			}
 
-				if taints.Value != nil {
-					taintsMap["value"] = taints.Value
-				}
+	// 			if taints.Value != nil {
+	// 				taintsMap["value"] = taints.Value
+	// 			}
 
-				if taints.Effect != nil {
-					taintsMap["effect"] = taints.Effect
-				}
+	// 			if taints.Effect != nil {
+	// 				taintsMap["effect"] = taints.Effect
+	// 			}
 
-				taintsList = append(taintsList, taintsMap)
-			}
+	// 			taintsList = append(taintsList, taintsMap)
+	// 		}
 
-			_ = d.Set("taints", taintsList)
-		}
-	}
+	// 		_ = d.Set("taints", taintsList)
+	// 	}
+	// }
 
 	return nil
 }

website/docs/r/kubernetes_cluster_attachment.html.markdown

@@ -117,6 +117,7 @@ The following arguments are supported:
 * `key_ids` - (Optional, List: [`String`], ForceNew) The key pair to use for the instance, it looks like skey-16jig7tx, it should be set if `password` not set.
 * `labels` - (Optional, Map, ForceNew) Labels of tke attachment exits CVM.
 * `password` - (Optional, String, ForceNew) Password to access, should be set if `key_ids` not set.
+* `security_groups` - (Optional, List: [`String`], ForceNew) A list of security group IDs after attach to cluster.
 * `unschedulable` - (Optional, Int, ForceNew) Sets whether the joining node participates in the schedule. Default is `0`, which means it participates in scheduling. Non-zero(eg: `1`) number means it does not participate in scheduling.
 * `worker_config_overrides` - (Optional, List, ForceNew) Override variable worker_config, commonly used to attach existing instances.
 * `worker_config` - (Optional, List, ForceNew) Deploy the machine configuration information of the 'WORKER', commonly used to attach existing instances.
@@ -191,7 +192,6 @@ The `worker_config` object supports the following:
 In addition to all arguments above, the following attributes are exported:
 
 * `id` - ID of the resource.
-* `security_groups` - A list of security group IDs after attach to cluster.
 * `state` - State of the node.