add

Author: SevenEarth

tencentcloud/services/cvm/resource_tc_eip.go

@@ -211,7 +211,11 @@ func resourceTencentCloudEipCreate(d *schema.ResourceData, meta interface{}) err
 			return resource.RetryableError(fmt.Errorf("eip id is nil"))
 		}
 		eipId = *response.Response.AddressSet[0]
-		taskId = *response.Response.TaskId
+		// taskId maybe nil
+		if response.Response.TaskId != nil {
+			taskId = *response.Response.TaskId
+		}
+
 		return nil
 	})
 	if err != nil {
@@ -220,43 +224,46 @@ func resourceTencentCloudEipCreate(d *schema.ResourceData, meta interface{}) err
 	d.SetId(eipId)
 
 	// wait for status
-	taskIdUint64, err := strconv.ParseUint(taskId, 10, 64)
-	if err != nil {
-		return err
-	}
-	taskRequest := vpc.NewDescribeTaskResultRequest()
-	taskRequest.TaskId = &taskIdUint64
-	err = resource.Retry(tccommon.ReadRetryTimeout, func() *resource.RetryError {
-		ratelimit.Check(taskRequest.GetAction())
-		taskResponse, err := client.UseVpcClient().DescribeTaskResult(taskRequest)
+	if taskId != "" {
+		taskIdUint64, err := strconv.ParseUint(taskId, 10, 64)
 		if err != nil {
-			return tccommon.RetryError(err)
-		}
-		if taskResponse.Response.Result != nil && *taskResponse.Response.Result == svcvpc.VPN_TASK_STATUS_RUNNING {
-			return resource.RetryableError(errors.New("eip task is running"))
+			return err
 		}
-		if taskResponse.Response.Result != nil && *taskResponse.Response.Result == svcvpc.VPN_TASK_STATUS_FAILED {
-			return resource.NonRetryableError(errors.New("eip task is failed"))
+		taskRequest := vpc.NewDescribeTaskResultRequest()
+		taskRequest.TaskId = &taskIdUint64
+		err = resource.Retry(3*tccommon.ReadRetryTimeout, func() *resource.RetryError {
+			ratelimit.Check(taskRequest.GetAction())
+			taskResponse, err := client.UseVpcClient().DescribeTaskResult(taskRequest)
+			if err != nil {
+				return tccommon.RetryError(err)
+			}
+			if taskResponse.Response.Result != nil && *taskResponse.Response.Result == svcvpc.VPN_TASK_STATUS_RUNNING {
+				return resource.RetryableError(errors.New("eip task is running"))
+			}
+			if taskResponse.Response.Result != nil && *taskResponse.Response.Result == svcvpc.VPN_TASK_STATUS_FAILED {
+				return resource.NonRetryableError(errors.New("eip task is failed"))
+			}
+			return nil
+		})
+		if err != nil {
+			return err
 		}
-		return nil
-	})
-	if err != nil {
-		return err
 	}
 
-	err = resource.Retry(tccommon.ReadRetryTimeout, func() *resource.RetryError {
+	err = resource.Retry(3*tccommon.ReadRetryTimeout, func() *resource.RetryError {
 		eip, errRet := vpcService.DescribeEipById(ctx, eipId)
 		if errRet != nil {
 			return tccommon.RetryError(errRet)
 		}
 		if eip == nil {
 			return resource.NonRetryableError(errors.New("eip is nil"))
 		}
-		if eip != nil && *eip.AddressStatus == svcvpc.EIP_STATUS_CREATING {
+		if eip.AddressStatus != nil && *eip.AddressStatus == svcvpc.EIP_STATUS_CREATING {
 			return resource.RetryableError(fmt.Errorf("eip is still creating"))
 		}
 		return nil
 	})
+
 	if err != nil {
 		return err
 	}