Fix lints

Author: tdeebswihart

common/persistence/sql/sqlplugin/mysql/session/session.go

@@ -47,7 +47,6 @@ type (
 		*sqlx.DB
 	}
 
-	// MySQLVersion specifies which of the distinct mysql versions we support
 	MySQLVersion int
 )
 
@@ -70,6 +69,7 @@ const (
 )
 
 var (
+	errUnspecifiedMySQLVersion                = errors.New("bug: mysql version left unspecified")
 	errMySQL8VisInterpolateParamsNotSupported = errors.New("interpolateParams is not supported for mysql8 visibility stores")
 	dsnAttrOverrides                          = map[string]string{
 		"parseTime":       "true",
@@ -95,7 +95,7 @@ func NewSession(
 	resolver resolver.ServiceResolver,
 ) (*Session, error) {
 	if version == MySQLVersionUnspecified {
-		return nil, fmt.Errorf("Bug: unspecified MySQL version provided to NewSession")
+		return nil, errUnspecifiedMySQLVersion
 	}
 
 	db, err := createConnection(version, dbKind, cfg, resolver)

common/persistence/sql/sqlplugin/mysql/session/session_test.go

@@ -173,7 +173,7 @@ func (s *sessionTestSuite) TestBuildDSN() {
 }
 
 func (s *sessionTestSuite) Test_MySQL8_Visibility_DoesntSupport_interpolateParams() {
-	config := config.SQL{
+	cfg := config.SQL{
 		User:              "test",
 		Password:          "pass",
 		ConnectProtocol:   "tcp",
@@ -182,8 +182,8 @@ func (s *sessionTestSuite) Test_MySQL8_Visibility_DoesntSupport_interpolateParam
 		ConnectAttributes: map[string]string{"interpolateParams": "ignored"},
 	}
 	r := resolver.NewMockServiceResolver(s.controller)
-	r.EXPECT().Resolve(config.ConnectAddr).Return([]string{config.ConnectAddr})
-	_, err := buildDSN(MySQLVersion8_0, sqlplugin.DbKindVisibility, &config, r)
+	r.EXPECT().Resolve(cfg.ConnectAddr).Return([]string{cfg.ConnectAddr})
+	_, err := buildDSN(MySQLVersion8_0, sqlplugin.DbKindVisibility, &cfg, r)
 	s.Error(err, "We should return an error when a MySQL8 Visibility database is configured with interpolateParams")
 }