Move the login complete page in the server

Since the logout complete page is in our server we should move the login complete page there too. This requires to get new parameter from the query string of the request to the localhost - loginCompleteUrl. Then we just redirect to it instead of serving local file.

Author: TsvetanMilanov

lib/services/authentication-service.ts

@@ -1,6 +1,5 @@
 import { ServerRequest, ServerResponse, Server } from "http";
 import { parse } from "url";
-import { join } from "path";
 import { isInteractive } from "../helpers";
 
 export class AuthenticationService implements IAuthenticationService {
@@ -32,19 +31,21 @@ export class AuthenticationService implements IAuthenticationService {
 		let loginUrl: string;
 		this.localhostServer = this.$httpServer.createServer({
 			routes: {
-				"/": async (request: ServerRequest, response: ServerResponse) => {
+				"/": (request: ServerRequest, response: ServerResponse) => {
 					this.$logger.debug("Login complete: " + request.url);
 					const parsedUrl = parse(request.url, true);
 					const loginResponse = parsedUrl.query.response;
 					if (loginResponse) {
-						await this.serveLoginFile("end.html")(request, response);
+						response.statusCode = 302;
+						response.setHeader("Location", parsedUrl.query.loginCompleteUrl);
 						this.killLocalhostServer();
 
 						isResolved = true;
 
 						const decodedResponse = new Buffer(loginResponse, "base64").toString();
 						this.rejectLoginPromiseAction = null;
 						authCompleteResolveAction(decodedResponse);
+						response.end();
 					} else {
 						this.$httpServer.redirect(response, loginUrl);
 					}
@@ -172,10 +173,6 @@ export class AuthenticationService implements IAuthenticationService {
 		return tokenState;
 	}
 
-	private serveLoginFile(relPath: string): (request: ServerRequest, response: ServerResponse) => Promise<void> {
-		return this.$httpServer.serveFile(join(__dirname, "..", "..", "resources", "login", relPath));
-	}
-
 	private killLocalhostServer(): void {
 		this.localhostServer.close();
 		this.localhostServer = null;