Use sync version of fs.chmod

Author: rosen-vladimirov

declarations.d.ts

@@ -338,8 +338,13 @@ interface IFileSystem {
 		string?: string;
 	}): any;
 
-	chmod(path: string, mode: number): IFuture<any>;
-	chmod(path: string, mode: string): IFuture<any>;
+	/**
+	 * Changes file mode of the specified file. In case it is a symlink, the original file's mode is modified.
+	 * @param {string} path Filepath to be modified.
+	 * @param {number | string} mode File mode.
+	 * @returns {void}
+	 */
+	chmod(path: string, mode: number | string): void;
 
 	setCurrentUserAsOwner(path: string, owner: string): IFuture<void>;
 	enumerateFilesInDirectorySync(directoryPath: string, filterCallback?: (file: string, stat: IFsStats) => boolean, opts?: { enumerateDirectories?: boolean, includeEmptyDirectories?: boolean }): string[];

file-system.ts

@@ -241,16 +241,8 @@ export class FileSystem implements IFileSystem {
 		return fs.createWriteStream(path, options);
 	}
 
-	public chmod(path: string, mode: any): IFuture<void> {
-		let future = new Future<void>();
-		fs.chmod(path, mode, (err: Error) => {
-			if (err) {
-				future.throw(err);
-			} else {
-				future.return();
-			}
-		});
-		return future;
+	public chmod(path: string, mode: any): void {
+		fs.chmodSync(path, mode);
 	}
 
 	public getFsStats(path: string): fs.Stats {

services/auto-completion-service.ts

@@ -220,7 +220,7 @@ export class AutoCompletionService implements IAutoCompletionService {
 					let clientExecutableFileName = (this.$staticConfig.CLIENT_NAME_ALIAS || this.$staticConfig.CLIENT_NAME).toLowerCase();
 					let pathToExecutableFile = path.join(__dirname, `../../../bin/${clientExecutableFileName}.js`);
 					this.$childProcess.exec(`"${process.argv[0]}" "${pathToExecutableFile}" completion >> "${filePath}"`).wait();
-					this.$fs.chmod(filePath, "0644").wait();
+					this.$fs.chmod(filePath, "0644");
 				}
 			} catch(err) {
 				this.$logger.out("Failed to update %s. Auto-completion may not work. ", filePath);

services/cancellation.ts

@@ -10,7 +10,7 @@ class CancellationService implements ICancellationService {
 	constructor(private $fs: IFileSystem,
 			private $logger: ILogger) {
 		this.$fs.createDirectory(CancellationService.killSwitchDir);
-		this.$fs.chmod(CancellationService.killSwitchDir, "0777").wait();
+		this.$fs.chmod(CancellationService.killSwitchDir, "0777");
 	}
 
 	public begin(name: string): IFuture<void> {
@@ -21,7 +21,7 @@ class CancellationService implements ICancellationService {
 				let streamEnd = this.$fs.futureFromEvent(stream, "finish");
 				stream.end();
 				streamEnd.wait();
-				this.$fs.chmod(triggerFile, "0777").wait();
+				this.$fs.chmod(triggerFile, "0777");
 			}
 
 			this.$logger.trace("Starting watch on killswitch %s", triggerFile);