Merge pull request #288 from telerik/fatme/fix-dynamic-commands

Generate dynamic commands only if the command starts with dynamic commands prefix

Author: Fatme

definitions/commands-service.d.ts

@@ -6,6 +6,7 @@ interface ICommandsService {
 }
 
 interface ICommandsServiceProvider {
+	dynamicCommandsPrefix: string;
 	getDynamicCommands(): IFuture<string[]>;
 	generateDynamicCommands(): IFuture<void>;
 	registerDynamicSubCommands(): void;

services/commands-service.ts

@@ -113,7 +113,7 @@ export class CommandsService implements ICommandsService {
 
 				this.$errors.fail("Unable to execute command '%s'. Use '$ %s %s --help' for help.", beautifiedName, this.$staticConfig.CLIENT_NAME.toLowerCase(), beautifiedName);
 				return false;
-			} else if(!isDynamicCommand){
+			} else if(!isDynamicCommand && _.startsWith(commandName, this.$commandsServiceProvider.dynamicCommandsPrefix)){
 				if(_.any(this.$commandsServiceProvider.getDynamicCommands().wait())) {
 					this.$commandsServiceProvider.generateDynamicCommands().wait();
 					return this.canExecuteCommand(commandName, commandArguments, true).wait();

services/html-help-service.ts

@@ -108,7 +108,7 @@ export class HtmlHelpService implements IHtmlHelpService {
 
 		var availableCommands = this.$injector.getRegisteredCommandsNames(false).sort();
 		this.$logger.trace("List of registered commands: %s", availableCommands.join(", "));
-		if(commandName && !_.contains(availableCommands, commandName)) {
+		if(commandName && _.startsWith(commandName, this.$commandsServiceProvider.dynamicCommandsPrefix) && !_.contains(availableCommands, commandName)) {
 			var dynamicCommands = this.$commandsServiceProvider.getDynamicCommands().wait();
 			if(!_.contains(dynamicCommands, commandName)) {
 				this.$errors.failWithoutHelp("Unknown command '%s'. Try '$ %s help' for a full list of supported commands.", commandName, this.$staticConfig.CLIENT_NAME.toLowerCase());