Merge pull request #309 from telerik/totev/fix-command-parameters-validation

teobugslayer · teobugslayer · commit 90d79b21a303 · 2015-04-28T16:06:52.000+03:00
Fixes validation of hierarchical commands with too many arguments
diff --git a/services/commands-service.ts b/services/commands-service.ts
@@ -144,7 +144,7 @@ export class CommandsService implements ICommandsService {
 					var argument = _.find(commandArgsHelper.remainingArguments, c => mandatoryParam.validate(c).wait());
 
 					if(argument) {
-						commandArgsHelper.remainingArguments = _.without(commandArgsHelper.remainingArguments, argument);
+						helpers.remove(commandArgsHelper.remainingArguments, arg => arg === argument);
 					}
 					else {
 						this.$errors.fail("Missing mandatory parameter.");

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ export class CommandsService implements ICommandsService {`
`144`	`144`	`var argument = _.find(commandArgsHelper.remainingArguments, c => mandatoryParam.validate(c).wait());`
`145`	`145`
`146`	`146`	`if(argument) {`
`147`		`- commandArgsHelper.remainingArguments = _.without(commandArgsHelper.remainingArguments, argument);`
	`147`	`+ helpers.remove(commandArgsHelper.remainingArguments, arg => arg === argument);`
`148`	`148`	`}`
`149`	`149`	`else {`
`150`	`150`	`this.$errors.fail("Missing mandatory parameter.");`