fix(deviceLogs): iOS device logs are not shown when deployOnDevices is used

When the public method `devicesService.deployOnDevices` is used, the device logs for iOS are not shown. The problem is that the method calls `canStartApplication`, which returns false on Windows.
Remove the check and also ensure the set of projectName for the deviceLogProvider will be called no matter of the way we start iOS Applications (through the mounted image or through Safari on device).

Author: rosen-vladimirov

mobile/application-manager-base.ts

@@ -70,11 +70,9 @@ export abstract class ApplicationManagerBase extends EventEmitter implements Mob
 
 	public async tryStartApplication(appData: Mobile.IApplicationData): Promise<void> {
 		try {
-			if (this.canStartApplication()) {
-				await this.startApplication(appData);
-			}
+			await this.startApplication(appData);
 		} catch (err) {
-			this.$logger.trace(`Unable to start application ${appData.appId}. Error is: ${err.message}`);
+			this.$logger.trace(`Unable to start application ${appData.appId} with name ${appData.projectName}. Error is: ${err.message}`);
 		}
 	}
 

mobile/ios/device/ios-application-manager.ts

@@ -102,6 +102,7 @@ export class IOSApplicationManager extends ApplicationManagerBase {
 
 	public async restartApplication(appData: Mobile.IApplicationData): Promise<void> {
 		try {
+			this.$deviceLogProvider.setProjectNameForDevice(this.device.deviceInfo.identifier, appData.projectName);
 			await this.stopApplication(appData);
 			await this.runApplicationCore(appData);
 		} catch (err) {

test/unit-tests/mobile/application-manager-base.ts

@@ -640,10 +640,9 @@ describe("ApplicationManagerBase", () => {
 	});
 
 	describe("tryStartApplication", () => {
-		it("calls startApplication, when canStartApplication returns true", async () => {
+		it("calls startApplication", async () => {
 			let passedApplicationData: Mobile.IApplicationData = null;
 
-			applicationManager.canStartApplication = () => true;
 			applicationManager.startApplication = (appData: Mobile.IApplicationData) => {
 				passedApplicationData = appData;
 				return Promise.resolve();
@@ -658,18 +657,6 @@ describe("ApplicationManagerBase", () => {
 
 		});
 
-		it("does not call startApplication, when canStartApplication returns false", async () => {
-			let isStartApplicationCalled = false;
-			applicationManager.canStartApplication = () => false;
-			applicationManager.startApplication = (appData: Mobile.IApplicationData) => {
-				isStartApplicationCalled = true;
-				return Promise.resolve();
-			};
-
-			await applicationManager.tryStartApplication(applicationData);
-			assert.isFalse(isStartApplicationCalled, "startApplication must not be called when canStartApplication returns false.");
-		});
-
 		describe("does not throw Error", () => {
 			const error = new Error("Throw!");
 			let isStartApplicationCalled = false;
@@ -696,16 +683,7 @@ describe("ApplicationManagerBase", () => {
 				assert.isTrue(logger.traceOutput.indexOf("Unable to start application") !== -1, "'Unable to start application' must be shown in trace output.");
 			};
 
-			it("when canStartApplication throws error", async () => {
-				applicationManager.canStartApplication = (): boolean => {
-					throw error;
-				};
-				applicationManager.isApplicationInstalled = (appId: string) => Promise.resolve(true);
-				await assertDoesNotThrow();
-			});
-
 			it("when startApplications throws", async () => {
-				applicationManager.canStartApplication = () => true;
 				applicationManager.isApplicationInstalled = (appId: string) => Promise.resolve(true);
 				await assertDoesNotThrow({ shouldStartApplicatinThrow: true });
 			});