Skip to content

Commit aa619a7

Browse files
committed
error::Error: remove some comments
Signed-off-by: Nick Cameron <[email protected]>
1 parent c235a11 commit aa619a7

File tree

2 files changed

+0
-30
lines changed

2 files changed

+0
-30
lines changed

core/src/error.rs

-15
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,6 @@
11
#![doc = include_str!("error.md")]
22
#![unstable(feature = "error_in_core", issue = "none")]
33

4-
// A note about crates and the facade:
5-
//
6-
// Originally, the `Error` trait was defined in libcore, and the impls
7-
// were scattered about. However, coherence objected to this
8-
// arrangement, because to create the blanket impls for `Box` required
9-
// knowing that `&str: !Error`, and we have no means to deal with that
10-
// sort of conflict just now. Therefore, for the time being, we have
11-
// moved the `Error` trait into libstd. As we evolve a sol'n to the
12-
// coherence challenge (e.g., specialization, neg impls, etc) we can
13-
// reconsider what crate these items belong in.
14-
154
#[cfg(test)]
165
mod tests;
176

@@ -417,10 +406,6 @@ impl dyn Error {
417406
// because that means the method can't be called on trait objects (we'd also need the
418407
// 'static bound, but that isn't allowed because methods with bounds on Self other than
419408
// Sized are not object-safe). Requiring an Unsize bound is not backwards compatible.
420-
//
421-
// Two possible solutions are to start the iterator at self.source() instead of self (see
422-
// discussion on the tracking issue), or to wait for dyn* to exist (which would then permit
423-
// the coercion).
424409

425410
Source { current: Some(self) }
426411
}

std/src/error.rs

-15
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,6 @@
11
#![doc = include_str!("../../core/src/error.md")]
22
#![stable(feature = "rust1", since = "1.0.0")]
33

4-
// A note about crates and the facade:
5-
//
6-
// Originally, the `Error` trait was defined in libcore, and the impls
7-
// were scattered about. However, coherence objected to this
8-
// arrangement, because to create the blanket impls for `Box` required
9-
// knowing that `&str: !Error`, and we have no means to deal with that
10-
// sort of conflict just now. Therefore, for the time being, we have
11-
// moved the `Error` trait into libstd. As we evolve a sol'n to the
12-
// coherence challenge (e.g., specialization, neg impls, etc) we can
13-
// reconsider what crate these items belong in.
14-
154
#[cfg(test)]
165
mod tests;
176

@@ -996,10 +985,6 @@ impl dyn Error {
996985
// because that means the method can't be called on trait objects (we'd also need the
997986
// 'static bound, but that isn't allowed because methods with bounds on Self other than
998987
// Sized are not object-safe). Requiring an Unsize bound is not backwards compatible.
999-
//
1000-
// Two possible solutions are to start the iterator at self.source() instead of self (see
1001-
// discussion on the tracking issue), or to wait for dyn* to exist (which would then permit
1002-
// the coercion).
1003988

1004989
Sources { current: Some(self) }
1005990
}

0 commit comments

Comments
 (0)