unix: Unsafe-wrap stack_overflow::cleanup

workingjubilee · workingjubilee · commit 72c7444faf01 · 2024-07-18T15:22:17.000-07:00
Editorialize on the wisdom of this as we do.
diff --git a/std/src/sys/pal/unix/stack_overflow.rs b/std/src/sys/pal/unix/stack_overflow.rs
@@ -155,8 +155,13 @@ mod imp {
         }
     }
 
+    /// # Safety
+    /// Must be called only once
+    #[forbid(unsafe_op_in_unsafe_fn)]
     pub unsafe fn cleanup() {
-        drop_handler(MAIN_ALTSTACK.load(Ordering::Relaxed));
+        // FIXME: I probably cause more bugs than I'm worth!
+        // see https://github.com/rust-lang/rust/issues/111272
+        unsafe { drop_handler(MAIN_ALTSTACK.load(Ordering::Relaxed)) };
     }
 
     unsafe fn get_stack() -> libc::stack_t {

Original file line number	Diff line number	Diff line change
`@@ -155,8 +155,13 @@ mod imp {`
`155`	`155`	`}`
`156`	`156`	`}`
`157`	`157`
	`158`	`+ /// # Safety`
	`159`	`+ /// Must be called only once`
	`160`	`+ #[forbid(unsafe_op_in_unsafe_fn)]`
`158`	`161`	`pub unsafe fn cleanup() {`
`159`		`- drop_handler(MAIN_ALTSTACK.load(Ordering::Relaxed));`
	`162`	`+ // FIXME: I probably cause more bugs than I'm worth!`
	`163`	`+ // see https://github.com/rust-lang/rust/issues/111272`
	`164`	`+ unsafe { drop_handler(MAIN_ALTSTACK.load(Ordering::Relaxed)) };`
`160`	`165`	`}`
`161`	`166`
`162`	`167`	`unsafe fn get_stack() -> libc::stack_t {`