Make truncation explicit

Author: peterschrammel

src/goto-cc/compile.cpp

@@ -328,7 +328,7 @@ bool compilet::is_elf_file(const std::string &file_name)
   {
     char buf[4];
     for(std::size_t i=0; i<4; i++)
-      buf[i] = in.get();
+      buf[i]=static_cast<char>(in.get());
     if(buf[0]==0x7f && buf[1]=='E' &&
         buf[2]=='L' && buf[3]=='F')
       return true;

src/goto-programs/read_bin_goto_object.cpp

@@ -177,17 +177,17 @@ bool read_bin_goto_object(
 
   {
     char hdr[4];
-    hdr[0]=in.get();
-    hdr[1]=in.get();
-    hdr[2]=in.get();
+    hdr[0]=static_cast<char>(in.get());
+    hdr[1]=static_cast<char>(in.get());
+    hdr[2]=static_cast<char>(in.get());
 
     if(hdr[0]=='G' && hdr[1]=='B' && hdr[2]=='F')
     {
       // OK!
     }
     else
     {
-      hdr[3]=in.get();
+      hdr[3]=static_cast<char>(in.get());
       if(hdr[0]==0x7f && hdr[1]=='G' && hdr[2]=='B' && hdr[3]=='F')
       {
         // OK!

src/util/irep_serialization.cpp

@@ -193,7 +193,7 @@ std::size_t irep_serializationt::read_gb_word(std::istream &in)
 
   while(in.good())
   {
-    unsigned char ch=in.get();
+    unsigned char ch=static_cast<unsigned char>(in.get());
     res|=(size_t(ch&0x7f))<<shift_distance;
     shift_distance+=7;
     if((ch&0x80)==0)
@@ -228,13 +228,13 @@ irep_idt irep_serializationt::read_gb_string(std::istream &in)
   char c;
   size_t length=0;
 
-  while((c = in.get()) != 0)
+  while((c = static_cast<char>(in.get())) != 0)
   {
     if(length>=read_buffer.size())
       read_buffer.resize(read_buffer.size()*2, 0);
 
     if(c=='\\') // escaped chars
-      read_buffer[length] = in.get();
+      read_buffer[length] = static_cast<char>(in.get());
     else
       read_buffer[length] = c;