Delete as_const on xvalue

romainbrenguier · romainbrenguier · commit 9cd1e5651662 · 2019-03-06T15:02:33.000Z
This is done similarly to the standard library (C++17) to avoid
returning a reference to a temporary value which may have been
destroyed.
diff --git a/src/util/as_const.h b/src/util/as_const.h
@@ -16,4 +16,8 @@ const T &as_const(T &value)
   return static_cast<const T &>(value);
 }
 
+/// Deleted to avoid calling as_const on an xvalue
+template <typename T>
+void as_const(T &&) = delete;
+
 #endif // CPROVER_UTIL_AS_CONST_H

Original file line number	Diff line number	Diff line change
`@@ -16,4 +16,8 @@ const T &as_const(T &value)`
`16`	`16`	`return static_cast<const T &>(value);`
`17`	`17`	`}`
`18`	`18`
	`19`	`+/// Deleted to avoid calling as_const on an xvalue`
	`20`	`+template <typename T>`
	`21`	`+void as_const(T &&) = delete;`
	`22`	`+`
`19`	`23`	`#endif // CPROVER_UTIL_AS_CONST_H`