Skip to content

Commit c345003

Browse files
ylobankovTotktonada
authored andcommitted
Fix false positive behavior when using '-j -1' opt
The problem is that the test-run.py script returns exit code 0 in case of using '-j -1' option even though some tests were failed during test run. This patch fixes this false positive behavior by checking test status in a proper way.
1 parent d7eff44 commit c345003

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

test-run.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,10 @@ def main_loop_consistent(failed_test_ids):
172172
worker_id = 1
173173
worker = task_group['gen_worker'](worker_id)
174174
for task_id in task_ids:
175-
short_status = worker.run_task(task_id)
175+
# The 'run_task' method returns a tuple of three items:
176+
# (short_status, result_checksum, duration). So taking the first
177+
# item of this tuple for failure check.
178+
short_status = worker.run_task(task_id)[0]
176179
if short_status == 'fail':
177180
reproduce_file_path = \
178181
get_reproduce_file(worker.name)

0 commit comments

Comments
 (0)