Skip to content

Commit 318ffa2

Browse files
committed
Handle fail of a non-default server in an app test
It is possible that a crash detector of a non-default instance calls for `kill_current_test()` and the greenlet that executes the current test will be killed. So it'll not set the returncode. See #252 for reproducer. Part of #65 Part of #157
1 parent 421e2c6 commit 318ffa2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/app_server.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ def execute(self, server):
7878
# See a comment in LuaTest.execute() for motivation of
7979
# SIGKILL usage.
8080
ts.stop_nondefault(signal=signal.SIGKILL)
81-
if retval['returncode'] != 0:
81+
if retval.get('returncode', None) != 0:
8282
raise TestExecutionError
8383

8484

0 commit comments

Comments
 (0)