Skip to content

Commit f37a845

Browse files
deps: bump msgpack requirement to 1.0.4
In this patch we bump msgpack requirement since version 1.0.4 has various vulnerability fixes (for example, [1]). Since the code is still compatible with msgpack-python and older msgpack, tests are not removed in this patch. 1. msgpack/msgpack-python#153
1 parent 60a2f38 commit f37a845

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

.github/workflows/testing.yml

+8-7
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
msgpack-deps: 'msgpack==0.6.2'
5454
- tarantool: '2.8'
5555
python: '3.10'
56-
msgpack-deps: 'msgpack==1.0.0'
56+
msgpack-deps: 'msgpack==1.0.4'
5757

5858
steps:
5959
- name: Clone the connector
@@ -81,12 +81,13 @@ jobs:
8181
run: |
8282
pip install ${{ matrix.msgpack-deps }}
8383
84-
- name: Install specific version of msgpack-python package
85-
# msgpack package is a replacement for deprecated msgpack-python.
86-
# To test compatibility with msgpack-python we must ignore
87-
# requirements.txt install of msgpack package by overwriting it
88-
# with sed.
89-
if: startsWith(matrix.msgpack-deps, 'msgpack-python==') == true
84+
- name: Install specific version of msgpack package
85+
# We want to enforce using modern msgpack since it has
86+
# various vulnerability fixes. But the code is compatible
87+
# with older msgpack versions and msgpack-python package.
88+
# To this test compatibility we must ignore requirements.txt
89+
# install of the newer msgpack package by overwriting it with sed.
90+
if: matrix.msgpack-deps != ''
9091
run: |
9192
pip install ${{ matrix.msgpack-deps }}
9293
sed -i -e "s/^msgpack.*$/${{ matrix.msgpack-deps }}/" requirements.txt

requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
msgpack>=0.4.0
1+
msgpack>=1.0.4

setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def find_version(*file_paths):
8383
cmdclass=cmdclass,
8484
command_options=command_options,
8585
install_requires=[
86-
'msgpack>=0.4.0',
86+
'msgpack>=1.0.4',
8787
],
8888
python_requires='>=3',
8989
)

0 commit comments

Comments
 (0)