Skip to content

Commit 52dcc3d

Browse files
deps: bump msgpack requirement to 1.0.4
In this patch we bump msgpack requirement since version 1.0.4 has various vulnerability fixes (for example, [1]). Since the code is still compatible with msgpack-python and older msgpack, tests are not removed in this patch. 1. msgpack/msgpack-python#153
1 parent a9bcded commit 52dcc3d

File tree

4 files changed

+12
-13
lines changed

4 files changed

+12
-13
lines changed

.github/workflows/testing.yml

+7-11
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
msgpack-deps: 'msgpack==0.6.2'
5454
- tarantool: '2.8'
5555
python: '3.10'
56-
msgpack-deps: 'msgpack==1.0.0'
56+
msgpack-deps: 'msgpack==1.0.4'
5757

5858
steps:
5959
- name: Clone the connector
@@ -77,16 +77,12 @@ jobs:
7777
python-version: ${{ matrix.python }}
7878

7979
- name: Install specific version of msgpack package
80-
if: startsWith(matrix.msgpack-deps, 'msgpack==') == true
81-
run: |
82-
pip install ${{ matrix.msgpack-deps }}
83-
84-
- name: Install specific version of msgpack-python package
85-
# msgpack package is a replacement for deprecated msgpack-python.
86-
# To test compatibility with msgpack-python we must ignore
87-
# requirements.txt install of msgpack package by overwriting it
88-
# with sed.
89-
if: startsWith(matrix.msgpack-deps, 'msgpack-python==') == true
80+
# We want to enforce using modern msgpack since it has
81+
# various vulnerability fixes. But the code is compatible
82+
# with older msgpack versions and msgpack-python package.
83+
# To this test compatibility we must ignore requirements.txt
84+
# install of the newer msgpack package by overwriting it with sed.
85+
if: matrix.msgpack-deps != ''
9086
run: |
9187
pip install ${{ matrix.msgpack-deps }}
9288
sed -i -e "s/^msgpack.*$/${{ matrix.msgpack-deps }}/" requirements.txt

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
99
### Added
1010

1111
### Changed
12+
- Bump msgpack requirement to 1.0.4 (PR #223).
13+
The only reason of this bump is various vulnerability fixes,
14+
msgpack>=0.4.0 and msgpack-python==0.4.0 are still supported.
1215

1316
### Fixed
1417

requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
msgpack>=0.4.0
1+
msgpack>=1.0.4

setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def find_version(*file_paths):
8383
cmdclass=cmdclass,
8484
command_options=command_options,
8585
install_requires=[
86-
'msgpack>=0.4.0',
86+
'msgpack>=1.0.4',
8787
],
8888
python_requires='>=3',
8989
)

0 commit comments

Comments
 (0)