Skip to content

Move php7-v2 to master #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Totktonada opened this issue Sep 11, 2018 · 3 comments
Closed

Move php7-v2 to master #137

Totktonada opened this issue Sep 11, 2018 · 3 comments
Assignees

Comments

@Totktonada
Copy link
Member

Totktonada commented Sep 11, 2018

It seems that community prefer php7 and now we can obsolete php5 support. I propose to move current master (php5) into the separate branch and move php7-v2 branch (force-push or merge, don't sure) to master.

Packages then will be build for php7, so #117 (and #136) will be fixed.

We need to elaborate what additional work is needed here: update docker images and so on.

@bigbes Can you please comment?

@Totktonada
Copy link
Member Author

Totktonada commented Mar 23, 2020

Blocked on:

@Totktonada Totktonada added this to the Support PHP 7.* milestone Mar 23, 2020
This was referenced Mar 24, 2020
@Totktonada
Copy link
Member Author

As part of this issue we should ensure that all commits into master branch since php7-v2 forking point are either unrelevant or reflected in the php7-v2 branch.

What to inspect:

$ git merge-base origin/master origin/php7-v2
61b9d7bc15d78e210b58e2a16feecdb3982923a9
$ git log 61b9d7bc15d78e210b58e2a16feecdb3982923a9..origin/master

@Totktonada
Copy link
Member Author

  • Created new php5 branch, which is even with current master (03fc9fe, 0.1.0-49-g03fc9fe).
  • Force-pushed master branch with latest php7-v2 commit (ad221f7, 0.3.2-39-gad221f7).
  • Changed target from php7-v2 to master in open PRs.

Nothing more to do here. We should carefully look at README (whether it is actual) as follow up. See also PR #129.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant