Add ability to give null to select in limit. closes gh-58

Author: bigbes

src/tarantool.c

@@ -913,13 +913,22 @@ PHP_METHOD(tarantool_class, ping) {
 PHP_METHOD(tarantool_class, select) {
 	zval *space = NULL, *index = NULL;
 	zval *key = NULL, *key_new = NULL;
+	zval *zlimit = NULL;
 	long limit = LONG_MAX-1, offset = 0, iterator = 0;
 
-	TARANTOOL_PARSE_PARAMS(id, "z|zzlll", &space, &key,
-			&index, &limit, &offset, &iterator);
+	TARANTOOL_PARSE_PARAMS(id, "z|zzzll", &space, &key,
+			&index, &zlimit, &offset, &iterator);
 	TARANTOOL_FETCH_OBJECT(obj, id);
 	TARANTOOL_CONNECT_ON_DEMAND(obj, id);
 
+	if (zlimit != NULL && Z_TYPE_P(zlimit) != IS_NULL && Z_TYPE_P(zlimit) != IS_LONG) {
+		THROW_EXC("wrong type of 'limit' - expected long/null, got '%s'",
+				zend_zval_type_name(zlimit));
+		RETURN_FALSE;
+	} else if (zlimit != NULL && Z_TYPE_P(zlimit) == IS_LONG) {
+		limit = Z_LVAL_P(zlimit);
+	}
+
 	long space_no = get_spaceno_by_name(obj, id, space TSRMLS_CC);
 	if (space_no == FAILURE) RETURN_FALSE;
 	int32_t index_no = 0;

test/DMLTest.php

@@ -259,4 +259,14 @@ public function test_13_eval() {
         $this->assertEquals(self::$tarantool->eval("return test_3(...)", array(3, 4)), array('0' => 7));
         $this->assertEquals(self::$tarantool->evaluate("return test_3(...)", array(3, 4)), array('0' => 7));
     }
+
+    public function test_14_select_limit_defaults() {
+        self::$tarantool->insert("test", array(1, 2, "hello"));
+        self::$tarantool->insert("test", array(2, 3, "hello"));
+        self::$tarantool->insert("test", array(3, 4, "hello"));
+        self::$tarantool->insert("test", array(4, 2, "hello"));
+        $this->assertEquals(count(self::$tarantool->select("test", 3, "secondary", null, null, TARANTOOL_ITER_GT)), 1);
+        $this->assertEquals(count(self::$tarantool->select("test", 3, "secondary", 0,    null, TARANTOOL_ITER_GT)), 0);
+        $this->assertEquals(count(self::$tarantool->select("test", 3, "secondary", 100,  null, TARANTOOL_ITER_GT)), 1);
+    }
 }