Skip to content

Commit 2f5c548

Browse files
committed
resolve the review issues
1 parent 5a869e2 commit 2f5c548

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

src/main/java/org/tarantool/jdbc/SQLStatement.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -335,10 +335,10 @@ protected boolean handleResult(Object result) throws SQLException {
335335
/**
336336
* Returns {@link ResultSet} which will be initialized by <code>data</code>
337337
*
338-
* @param data predifined result to be wrapped by {@link ResultSet}
338+
* @param data predefined result to be wrapped by {@link ResultSet}
339339
* @return wrapped result
340340
* @throws SQLException if a database access error occurs or
341-
* this method is called on a closed <code>Statement</code>
341+
* this method is called on a closed <code>Statement</code>
342342
*/
343343
public ResultSet executeMetadata(JDBCBridge data) throws SQLException {
344344
checkNotClosed();

src/test/java/org/tarantool/jdbc/JdbcConnectionIT.java

+4-7
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222

2323
@SuppressWarnings("Since15")
2424
public class JdbcConnectionIT extends AbstractJdbcIT {
25+
2526
@Test
2627
public void testCreateStatement() throws SQLException {
2728
Statement stmt = conn.createStatement();
@@ -125,17 +126,13 @@ public void testConnectionIsWrapperFor() throws SQLException {
125126
}
126127

127128
@Test
128-
public void testGetHoldability() throws SQLException {
129+
public void testDefaultGetHoldability() throws SQLException {
129130
// default connection holdability should be equal to metadata one
130131
assertEquals(conn.getMetaData().getResultSetHoldability(), conn.getHoldability());
131-
132-
// change connection holdability
133-
conn.setHoldability(ResultSet.HOLD_CURSORS_OVER_COMMIT);
134-
assertEquals(ResultSet.HOLD_CURSORS_OVER_COMMIT, conn.getHoldability());
135132
}
136133

137134
@Test
138-
public void testSetHoldability() throws SQLException {
135+
public void testSetAndGetHoldability() throws SQLException {
139136
conn.setHoldability(ResultSet.HOLD_CURSORS_OVER_COMMIT);
140137
assertEquals(ResultSet.HOLD_CURSORS_OVER_COMMIT, conn.getHoldability());
141138

@@ -195,4 +192,4 @@ public void testPrepareHoldableStatement() throws SQLException {
195192
});
196193
}
197194

198-
}
195+
}

0 commit comments

Comments
 (0)