Skip to content

Commit 4fbdf80

Browse files
committed
cd: remove attempt to print secrets to the log
According to [1] printing secrets to the log is not a best practice. From [1]: GitHub automatically redacts secrets printed to the log, but you should avoid printing secrets to the log intentionally. [1] https://docs.github.com/en/actions/security-guides/encrypted-secrets#accessing-your-secrets
1 parent b0c2020 commit 4fbdf80

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

.github/workflows/packaging.yml

+9-1
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,18 @@ jobs:
7777
-u ${RWS_AUTH} \
7878
-F product=${PRODUCT_NAME}"
7979
80+
# We don't want to try to print secrets to the log, but we want
81+
# to print a "curl" command to see what's going on.
82+
CURL_CMD_ECHO="curl -LfsS \
83+
-X PUT ${RWS_URL_PART}/${OS}/${DIST} \
84+
-u *** \
85+
-F product=${PRODUCT_NAME}"
86+
8087
for f in $(ls -I '*build*' -I '*.changes' ./build); do
8188
CURL_CMD+=" -F $(basename ${f})=@./build/${f}"
89+
CURL_CMD_ECHO+=" -F $(basename ${f})=@./build/${f}"
8290
done
8391
84-
echo ${CURL_CMD}
92+
echo ${CURL_CMD_ECHO}
8593
8694
${CURL_CMD}

0 commit comments

Comments
 (0)