Skip to content

Commit fda6d64

Browse files
committed
Add nemeses support to runner and db
Works: clock nemesis Closes #34 Closes #25 (clock) Needed for #16 (kill) Needed for #17 (partition) Needed for #21 (pause)
1 parent aa588b1 commit fda6d64

File tree

2 files changed

+74
-12
lines changed

2 files changed

+74
-12
lines changed

src/tarantool/nemesis.clj

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
(ns tarantool.nemesis
2+
"Nemeses for Tarantool"
3+
(:require [clojure.pprint :refer [pprint]]
4+
[clojure.tools.logging :refer [info warn]]
5+
[dom-top.core :refer [real-pmap]]
6+
[jepsen [nemesis :as n]
7+
[net :as net]
8+
[util :as util]]
9+
[jepsen.generator :as gen]
10+
[jepsen.nemesis [combined :as nc]
11+
[time :as nt]]))
12+
13+
(defn nemesis-package
14+
"Constructs a nemesis and generators for Tarantool"
15+
[opts]
16+
(let [opts (update opts :faults set)]
17+
(nc/nemesis-package opts)))

src/tarantool/runner.clj

Lines changed: 57 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@
1212
[control :as c]
1313
[independent :as independent]
1414
[generator :as gen]
15-
[nemesis :as nemesis]
1615
[tests :as tests]
1716
[util :refer [timeout meh]]]
1817
[jepsen.checker.timeline :as timeline]
1918
;[knossos.model :as model]
2019
[jepsen.os.ubuntu :as ubuntu]
2120
[tarantool [db :as db]
2221
[errcode :as err]
22+
[nemesis :as nemesis]
2323
[register :as register]
2424
[sets :as sets]
2525
[counter :as counter]]))
@@ -76,6 +76,32 @@
7676
;:pages {:serialized-indices [true false]}
7777
:register {}})
7878

79+
(def nemeses
80+
"Types of faults a nemesis can create."
81+
#{:pause :kill :partition :clock})
82+
83+
(def standard-nemeses
84+
"Combinations of nemeses for tests."
85+
[[]
86+
[:pause]
87+
[:kill]
88+
[:partition]
89+
[:pause :kill :partition :clock]])
90+
91+
(def special-nemeses
92+
"A map of special nemesis names to collections of faults."
93+
{:none []
94+
:standard [:pause :kill :partition :clock]
95+
:all [:pause :kill :partition :clock]})
96+
97+
(defn parse-nemesis-spec
98+
"Takes a comma-separated nemesis string and
99+
returns a collection of keyword faults."
100+
[spec]
101+
(->> (str/split spec #",")
102+
(map keyword)
103+
(mapcat #(get special-nemeses % [%]))))
104+
79105
(def cli-opts
80106
"Options for test runners."
81107
[["-v" "--version VERSION"
@@ -84,6 +110,15 @@
84110
[nil "--mvcc"
85111
"Enable MVCC engine"
86112
:default false]
113+
[nil "--nemesis FAULTS" "A comma-separated list of nemesis faults to enable"
114+
:parse-fn parse-nemesis-spec
115+
:validate [(partial every? (into nemeses (keys special-nemeses)))
116+
(str "Faults must be one of " nemeses " or "
117+
(cli/one-of special-nemeses))]]
118+
[nil "--nemesis-interval SECONDS" "How long to wait between nemesis faults"
119+
:default 3
120+
:parse-fn read-string
121+
:validate [#(and (number? %) (pos? %)) "must be a positive number"]]
87122
["-e" "--engine NAME"
88123
"What Tarantool data engine should we use?"
89124
:default "memtx"]])
@@ -142,7 +177,15 @@
142177
(defn tarantool-test
143178
[opts]
144179
(let [workload ((get workloads (:workload opts)) opts)
145-
nemesis nemesis/noop
180+
nemesis (nemesis/nemesis-package
181+
{:db db/db
182+
:nodes (:nodes opts)
183+
:faults (:nemesis opts)
184+
:partition {:targets [:primaries]}
185+
:pause {:targets [nil :one :primaries :majority :all]}
186+
:kill {:targets [nil :one :primaries :majority :all]}
187+
:interval (:nemesis-interval opts)})
188+
_ (info (pr-str nemesis))
146189
gen (->> (:generator workload)
147190
(gen/nemesis (:generator nemesis))
148191
(gen/time-limit (:time-limit opts)))
@@ -156,7 +199,7 @@
156199
(merge tests/noop-test
157200
opts
158201
{:client (:client workload)
159-
:nemesis nemesis
202+
:nemesis (:nemesis nemesis)
160203
:name (str "tarantool-" (:version opts))
161204
:os ubuntu/os
162205
:db (db/db (:version opts))
@@ -168,7 +211,7 @@
168211
10
169212
(:concurrency opts))
170213
:generator gen
171-
:checker (checker/compose {:perf (checker/perf)
214+
:checker (checker/compose {:perf (checker/perf {:nemeses (:perf nemesis)})
172215
:clock-skew (checker/clock-plot)
173216
:crash (crash-checker)
174217
:timeline (timeline/html)
@@ -177,22 +220,24 @@
177220
:workload (:checker workload)})})))
178221

179222
(defn all-test-options
180-
"Takes base cli options, a collection of workloads, and a test count,
223+
"Takes base cli options, a collection of nemeses, workloads, and a test count,
181224
and constructs a sequence of test options."
182-
[cli workloads]
183-
(for [w workloads, i (range (:test-count cli))]
225+
[cli nemeses workloads]
226+
(for [n nemeses, w workloads, i (range (:test-count cli))]
184227
(assoc cli
228+
:nemesis n
185229
:workload w)))
186230

187231
(defn all-tests
188232
"Takes parsed CLI options and constructs a sequence of test options, by
189-
combining all workloads."
190-
[test-fn opts]
191-
(let [workloads (if-let [w (:workload opts)] [w]
192-
(if (:only-workloads-expected-to-pass opts)
233+
combining all workloads and nemeses."
234+
[test-fn cli]
235+
(let [nemeses (if-let [n (:nemesis cli)] [n] standard-nemeses)
236+
workloads (if-let [w (:workload cli)] [w]
237+
(if (:only-workloads-expected-to-pass cli)
193238
workloads-expected-to-pass
194239
standard-workloads))]
195-
(->> (all-test-options opts workloads)
240+
(->> (all-test-options cli nemeses workloads)
196241
(map test-fn))))
197242

198243
(defn -main

0 commit comments

Comments
 (0)