WIP: Preliminary patch for update/delete mutations

Author: Totktonada

graphql/accessor_general.lua

@@ -1486,10 +1486,43 @@ function accessor_general.new(opts, funcs)
             extra_args = function(self, collection_name)
                 local collection = self.collections[collection_name]
                 local schema_name = collection.schema_name
-                local schema = table.copy(self.schemas[schema_name])
-                schema.name = collection_name .. '_insert'
+
+                local schema_insert = table.copy(self.schemas[schema_name])
+                schema_insert.name = collection_name .. '_insert'
+
+                -- XXX: opts.multi
+                local schema_update = {
+                    name = collection_name .. '_update',
+                    type = 'record',
+                    fields = {},
+                }
+                for _, field in ipairs(self.schemas[schema_name].fields) do
+                    local field = table.copy(field)
+                    field.type = avro_helpers.make_avro_type_nullable(
+                        field.type)
+                    table.insert(schema_update.fields, field)
+                end
+
+                -- XXX: opts.multi
+                local schema_delete = 'boolean'
+
                 return {
-                    {name = 'insert', type = schema}
+                    {name = 'insert', type = schema_insert},
+                    {name = 'update', type = schema_update},
+                    {name = 'delete', type = schema_delete},
+                }, {
+                    insert = {
+                        add_to_mutations_only = true,
+                        add_to_top_fields_only = true,
+                    },
+                    update = {
+                        add_to_mutations_only = true,
+                        add_to_top_fields_only = false,
+                    },
+                    delete = {
+                        add_to_mutations_only = true,
+                        add_to_top_fields_only = false,
+                    },
                 }
             end,
         }

graphql/tarantool_graphql.lua

@@ -1248,16 +1248,26 @@ local function create_root_collection(state)
         root_types[what] = nullable(gql_type(state, root_schema,
             root_collection, nil))
 
-    end
-
-    -- add extra arguments to top-level fields (collections)
-    for collection_name, field in pairs(root_types['Mutation'].fields) do
-        -- Prevent exposing an argument into the query schema subtree (it is
-        -- needed because we use a booking table for arguments).
-        field.arguments = table.copy(field.arguments)
-
-        for name, arg in pairs(state.extra_arguments[collection_name]) do
-            field.arguments[name] = arg
+        -- add extra arguments to top-level fields (collections)
+        for collection_name, field in pairs(root_types[what].fields) do
+            -- Prevent exposing an argument inserted, say, into the mutation schema
+            -- subtree to the query subtree (it is needed because we use a booking
+            -- table for arguments).
+            field.arguments = table.copy(field.arguments)
+
+            local extra_args = state.extra_arguments[collection_name]
+            local extra_args_meta = state.extra_arguments_meta[collection_name]
+
+            for arg_name, arg in pairs(extra_args) do
+                local meta = extra_args_meta[arg_name]
+                check(meta, 'meta', 'table')
+                -- note: we handle add_to_top_fields_only == false case in
+                -- add_connection_arguments
+                if meta.add_to_top_fields_only and what == 'Mutation' or
+                        not meta.add_to_mutations_only then
+                    field.arguments[arg_name] = arg
+                end
+            end
         end
     end
 
@@ -1343,6 +1353,8 @@ local function add_connection_arguments(state)
             }
         end
     end)
+
+    -- XXX: handle add_to_top_fields_only == false case of extra_arguments
 end
 
 local function parse_cfg(cfg)
@@ -1362,6 +1374,7 @@ local function parse_cfg(cfg)
     -- argument. We capture extra_arguments[collection_name] into the resolve
     -- function and sure it exists and will not be changed.
     state.extra_arguments = utils.gen_booking_table({})
+    state.extra_arguments_meta = {}
 
     -- map from avro-schema names to graphql types
     state.definitions = {}
@@ -1415,12 +1428,16 @@ local function parse_cfg(cfg)
             {skip_compound = true})
         local list_args = convert_record_fields_to_args(
             accessor:list_args(collection_name))
-        local extra_args = convert_record_fields_to_args(
-            accessor:extra_args(collection_name), {dont_skip = true})
+        local extra_args_avro, extra_args_meta = accessor:extra_args(
+            collection_name)
+        check(extra_args_meta, 'extra_args_meta', 'table')
+        local extra_args = convert_record_fields_to_args(extra_args_avro,
+            {dont_skip = true})
 
         state.object_arguments[collection_name] = object_args
         state.list_arguments[collection_name] = list_args
         state.extra_arguments[collection_name] = extra_args
+        state.extra_arguments_meta[collection_name] = extra_args_meta
     end
 
     add_connection_arguments(state)
@@ -1683,7 +1700,14 @@ end
 ---                 }
 ---             end,
 ---             extra_args = function(self, collection_name)
----                 return ...
+---                 ...
+---                 local args_meta = {
+---                     arg_name = {
+---                         add_to_mutations_only = true / false,
+---                         add_to_top_fields_only = true / false,
+---                     }
+---                 }
+---                 return schemas_list, args_meta
 ---             end
 ---         }
 ---     }),