Verify 1:1 connection use all fields of an index

We already check that the index is unique. The tuples given by a
connection cannot be proven unique unless we match the tuples using
*full* list of key parts of an unique index.

Author: Totktonada

graphql/accessor_general.lua

@@ -405,9 +405,10 @@ end
 ---
 --- @tparam table indexes map from collection names to indexes meta-information
 --- as defined in the @{new} function; the function uses it to validate index
---- names provided in connections (which are inside collections) and validate
+--- names provided in connections (which are inside collections), validate
 --- connection types ('1:1' or '1:N') against index uniqueness if the `unique`
---- flag provided for corresponding index
+--- flag provided for corresponding index and to check that destination parts
+--- of connections form a prefix of parts of the `connection.index_name` index
 ---
 --- @tparam table collections map from collection names to collections as
 --- defined in the @{accessor_general.new} function decription; the function
@@ -431,16 +432,41 @@ local function build_connection_indexes(indexes, collections)
                 'index_name must be a string, got ' .. type(index_name))
 
             -- validate index_name against 'indexes'
-            local index = indexes[c.destination_collection]
-            assert(type(index) == 'table',
-                'index must be a table, got ' .. type(index))
+            local index_meta = indexes[c.destination_collection]
+            assert(type(index_meta) == 'table',
+                'index_meta must be a table, got ' .. type(index_meta))
 
-            -- XXX: validate connection parts are match or being prefix of
-            -- index fields
+            -- validate connection parts are match or being prefix of index
+            -- fields
+            local i = 1
+            local index_fields = index_meta[c.index_name].fields
+            for _, part in ipairs(c.parts) do
+                assert(type(part.source_field) == 'string',
+                    'part.source_field must be a string, got ' ..
+                    type(part.source_field))
+                assert(type(part.destination_field) == 'string',
+                    'part.destination_field must be a string, got ' ..
+                    type(part.destination_field))
+                assert(part.destination_field == index_fields[i],
+                    ('connection "%s" of collection "%s" ' ..
+                    'has destination parts that is not prefix of the index ' ..
+                    '"%s" parts'):format(c.name, c.destination_collection,
+                    c.index_name))
+                i = i + 1
+            end
+            local parts_cnt = i - 1
+
+            -- partial index of an unique index is not guaranteed to being
+            -- unique
+            assert(c.type == '1:N' or parts_cnt == #index_fields,
+                ('1:1 connection "%s" of collection "%s" ' ..
+                'has less fields than the index "%s" has (cannot prove ' ..
+                'uniqueness of the partial index)'):format(c.name,
+                c.destination_collection, c.index_name))
 
             -- validate connection type against index uniqueness (if provided)
-            if index.unique ~= nil then
-                assert(c.type == '1:N' or index.unique == true,
+            if index_meta.unique ~= nil then
+                assert(c.type == '1:N' or index_meta.unique == true,
                     ('1:1 connection ("%s") cannot be implemented ' ..
                     'on top of non-unique index ("%s")'):format(
                     c.name, index_name))
@@ -478,13 +504,8 @@ end
 --- @{tarantool_graphql.new} function; this is for validate collection against
 --- certain set of schemas (no 'dangling' schema names in collections)
 ---
---- @tparam table indexes map from collection names to indexes meta-information
---- as defined in the @{new} function; the function uses it to check that
---- destination parts of connections form a prefix of parts of the
---- `connection.index_name` index
----
 --- @return nil
-local function validate_collections(collections, schemas, indexes)
+local function validate_collections(collections, schemas)
     for collection_name, collection in pairs(collections) do
         assert(type(collection_name) == 'string',
             'collection_name must be a string, got ' ..
@@ -517,22 +538,6 @@ local function validate_collections(collections, schemas, indexes)
             assert(type(connection.index_name) == 'string',
                 'connection.index_name must be a string, got ' ..
                 type(connection.index_name))
-            local i = 1
-            for _, part in ipairs(connection.parts) do
-                assert(type(part.source_field) == 'string',
-                    'part.source_field must be a string, got ' ..
-                    type(part.source_field))
-                assert(type(part.destination_field) == 'string',
-                    'part.destination_field must be a string, got ' ..
-                    type(part.destination_field))
-                assert(part.destination_field ==
-                    indexes[collection_name][connection.index_name].fields[i],
-                    ('connection "%s" of collection "%s" ' ..
-                    'has destination parts that is not prefix of the index ' ..
-                    '"%s" parts'):format(connection.name, collection_name,
-                    connection.index_name))
-                i = i + 1
-            end
         end
     end
 end

test/local/init_fail.result

@@ -0,0 +1,2 @@
+INIT: ok: false; err: 1:1 connection "user_connection" of collection "user_collection" has less fields than the index "user_str_num_index" has (cannot prove uniqueness of the partial index)
+INIT: ok: true; type(res): table

test/local/init_fail.test.lua

@@ -0,0 +1,73 @@
+#!/usr/bin/env tarantool
+
+local fio = require('fio')
+
+-- require in-repo version of graphql/ sources despite current working directory
+package.path = fio.abspath(debug.getinfo(1).source:match("@?(.*/)")
+    :gsub('/./', '/'):gsub('/+$', '')) .. '/../../?.lua' .. ';' ..
+    package.path
+
+local graphql = require('graphql')
+local testdata = require('test.local.space_compound_index_testdata')
+
+-- utils
+-- -----
+
+-- return an error w/o file name and line number
+local function strip_error(err)
+    return tostring(err):gsub('^.-:.-: (.*)$', '%1')
+end
+
+-- init box, upload test data and acquire metadata
+-- -----------------------------------------------
+
+-- init box and data schema
+testdata.init_spaces()
+
+-- upload test data
+testdata.fill_test_data()
+
+-- acquire metadata
+local metadata = testdata.get_test_metadata()
+
+-- inject an error into the metadata
+-- ---------------------------------
+
+local saved_part =
+    metadata.collections.order_collection.connections[1].parts[2]
+metadata.collections.order_collection.connections[1].parts[2] = nil
+
+-- build accessor and graphql schemas
+-- ----------------------------------
+
+local function create_gql_wrapper(metadata)
+    local accessor = graphql.accessor_space.new({
+        schemas = metadata.schemas,
+        collections = metadata.collections,
+        service_fields = metadata.service_fields,
+        indexes = metadata.indexes,
+    })
+
+    return graphql.new({
+        schemas = metadata.schemas,
+        collections = metadata.collections,
+        accessor = accessor,
+    })
+
+end
+
+local ok, err = pcall(create_gql_wrapper, metadata)
+print(('INIT: ok: %s; err: %s'):format(tostring(ok), strip_error(err)))
+
+-- restore back cut part
+metadata.collections.order_collection.connections[1].parts[2] = saved_part
+
+local ok, res = pcall(create_gql_wrapper, metadata)
+print(('INIT: ok: %s; type(res): %s'):format(tostring(ok), type(res)))
+
+-- clean up
+-- --------
+
+testdata.drop()
+
+os.exit()

test/local/space_compound_index.test.lua

@@ -7,10 +7,10 @@ package.path = fio.abspath(debug.getinfo(1).source:match("@?(.*/)")
     :gsub('/./', '/'):gsub('/+$', '')) .. '/../../?.lua' .. ';' ..
     package.path
 
-local json = require('json')
 local yaml = require('yaml')
 local graphql = require('graphql')
 local utils = require('graphql.utils')
+local testdata = require('test.local.space_compound_index_testdata')
 
 -- utils
 -- -----
@@ -20,164 +20,21 @@ local function strip_error(err)
     return tostring(err):gsub('^.-:.-: (.*)$', '%1')
 end
 
--- schemas and meta-information
--- ----------------------------
-
-local schemas = json.decode([[{
-    "user": {
-        "type": "record",
-        "name": "user",
-        "fields": [
-            { "name": "user_str", "type": "string" },
-            { "name": "user_num", "type": "long" },
-            { "name": "first_name", "type": "string" },
-            { "name": "last_name", "type": "string" }
-        ]
-    },
-    "order": {
-        "type": "record",
-        "name": "order",
-        "fields": [
-            { "name": "order_str", "type": "string" },
-            { "name": "order_num", "type": "long" },
-            { "name": "user_str", "type": "string" },
-            { "name": "user_num", "type": "long" },
-            { "name": "description", "type": "string" }
-        ]
-    }
-}]])
-
-local collections = json.decode([[{
-    "user_collection": {
-        "schema_name": "user",
-        "connections": [
-            {
-                "type": "1:N",
-                "name": "order_connection",
-                "destination_collection": "order_collection",
-                "parts": [
-                    { "source_field": "user_str", "destination_field": "user_str" },
-                    { "source_field": "user_num", "destination_field": "user_num" }
-                ],
-                "index_name": "user_str_num_index"
-            },
-            {
-                "type": "1:N",
-                "name": "order_str_connection",
-                "destination_collection": "order_collection",
-                "parts": [
-                    { "source_field": "user_str", "destination_field": "user_str" }
-                ],
-                "index_name": "user_str_num_index"
-            }
-        ]
-    },
-    "order_collection": {
-        "schema_name": "order",
-        "connections": [
-            {
-                "type": "1:1",
-                "name": "user_connection",
-                "destination_collection":  "user_collection",
-                "parts": [
-                    { "source_field": "user_str", "destination_field": "user_str" },
-                    { "source_field": "user_num", "destination_field": "user_num" }
-                ],
-                "index_name": "user_str_num_index"
-            }
-        ]
-    }
-}]])
-
-local service_fields = {
-    user = {},
-    order = {},
-}
-
-local indexes = {
-    user_collection = {
-        user_str_num_index = {
-            service_fields = {},
-            fields = {'user_str', 'user_num'},
-            index_type = 'tree',
-            unique = true,
-            primary = true,
-        },
-    },
-    order_collection = {
-        order_str_num_index = {
-            service_fields = {},
-            fields = {'order_str', 'order_num'},
-            index_type = 'tree',
-            unique = true,
-            primary = true,
-        },
-        user_str_num_index = {
-            service_fields = {},
-            fields = {'user_str', 'user_num'},
-            index_type = 'tree',
-            unique = false,
-            primary = false,
-        },
-    },
-}
-
--- fill spaces
--- -----------
-
--- user_collection fields
-local U_USER_STR_FN = 1
-local U_USER_NUM_FN = 2
-
--- order_collection fields
-local O_ORDER_STR_FN = 1
-local O_ORDER_NUM_FN = 2
-local O_USER_STR_FN = 3
-local O_USER_NUM_FN = 4
-
-box.cfg{background = false}
-box.once('test_space_init_spaces', function()
-    -- users
-    box.schema.create_space('user_collection')
-    box.space.user_collection:create_index('user_str_num_index',
-        {type = 'tree', unique = true, parts = {
-            U_USER_STR_FN, 'string', U_USER_NUM_FN, 'unsigned',
-        }}
-    )
-
-    -- orders
-    box.schema.create_space('order_collection')
-    box.space.order_collection:create_index('order_str_num_index',
-        {type = 'tree', unique = true, parts = {
-            O_ORDER_STR_FN, 'string', O_ORDER_NUM_FN, 'unsigned',
-        }}
-    )
-    box.space.order_collection:create_index('user_str_num_index',
-        {type = 'tree', unique = false, parts = {
-            O_USER_STR_FN, 'string', O_USER_NUM_FN, 'unsigned',
-        }}
-    )
-end)
+-- init box, upload test data and acquire metadata
+-- -----------------------------------------------
 
-for i = 1, 20 do
-    for j = 1, 5 do
-        local s =
-            j % 5 == 1 and 'a' or
-            j % 5 == 2 and 'b' or
-            j % 5 == 3 and 'c' or
-            j % 5 == 4 and 'd' or
-            j % 5 == 0 and 'e' or
-            nil
-        assert(s ~= nil, 's must not be nil')
-        box.space.user_collection:replace(
-            {'user_str_' .. s, i, 'first name ' .. s, 'last name ' .. s})
-        for k = 1, 10 do
-            box.space.order_collection:replace(
-                {'order_str_' .. s .. '_' .. tostring(k), i * 100 + k,
-                'user_str_' .. s, i, 'description ' .. s})
-        end
-    end
-end
+-- init box and data schema
+testdata.init_spaces()
+
+-- upload test data
+testdata.fill_test_data()
+
+-- acquire metadata
+local metadata = testdata.get_test_metadata()
+local schemas = metadata.schemas
+local collections = metadata.collections
+local service_fields = metadata.service_fields
+local indexes = metadata.indexes
 
 -- build accessor and graphql schemas
 -- ----------------------------------
@@ -381,8 +238,6 @@ print(('RESULT: ok: %s; err: %s'):format(tostring(ok), strip_error(err)))
 -- clean up
 -- --------
 
-box.space._schema:delete('oncetest_space_init_spaces')
-box.space.user_collection:drop()
-box.space.order_collection:drop()
+testdata.drop()
 
 os.exit()