fixes [TO SQUASH]

Author: oleg-jukovec

datetime/config.lua

@@ -27,26 +27,6 @@ box.once("init", function()
     })
     s_1:truncate()
 
-    local s_2 = box.schema.space.create('testDatetime_2', {
-        id = 525,
-        if_not_exists = true,
-    })
-    s_2:format({
-        { 'Cid', type = 'unsigned' },
-        { 'Datetime', type = 'datetime' },
-        { 'Orig', type = 'unsigned' },
-        { 'Member', type = 'array' },
-    })
-    s_2:create_index('primary', {
-        type = 'tree',
-        parts = {
-            { field = 1, type = 'unsigned'},
-            { field = 2, type = 'datetime'},
-        },
-        if_not_exists = true
-    })
-    s_2:truncate()
-
     local s_3 = box.schema.space.create('testDatetime_3', {
         id = 526,
         if_not_exists = true,
@@ -55,15 +35,13 @@ box.once("init", function()
         type = 'tree',
         parts = {
             {1, 'uint'},
-            {2, 'datetime'}
         },
         if_not_exists = true
     })
     s_3:truncate()
 
     box.schema.func.create('call_me_maybe')
     box.schema.user.grant('test', 'read,write', 'space', 'testDatetime_1', { if_not_exists = true })
-    box.schema.user.grant('test', 'read,write', 'space', 'testDatetime_2', { if_not_exists = true })
     box.schema.user.grant('test', 'read,write', 'space', 'testDatetime_3', { if_not_exists = true })
 end)
 
@@ -74,9 +52,9 @@ local function call_me_maybe()
     return {
         {
             5, "Poyekhali!", {
-                {dt1, "Klushino"},
-                {dt2, "Baikonur"},
-                {dt3, "Novoselovo"},
+                {"Klushino", dt1},
+                {"Baikonur", dt2},
+                {"Novoselovo", dt3},
             },
         }
     }

datetime/datetime.go

@@ -76,10 +76,10 @@ type DateTime struct {
 
 // NewDateTime returns a pointer to a new datetime.DateTime that contains a
 // specified time.Time.
-func NewDateTime(t time.Time) DateTime {
+func NewDateTime(t time.Time) *DateTime {
 	dt := new(DateTime)
 	dt.time = t
-	return *dt
+	return dt
 }
 
 // ToTime returns a time.Time that DateTime contains.
@@ -131,7 +131,7 @@ func (tm *DateTime) UnmarshalMsgpack(b []byte) error {
 		dt.tzIndex = int16(binary.LittleEndian.Uint16(b[secondsSize+nsecSize+tzOffsetSize:]))
 	}
 	tt := time.Unix(dt.seconds, int64(dt.nsec)).UTC()
-	*tm = NewDateTime(tt)
+	*tm = *NewDateTime(tt)
 
 	return nil
 }