BUG: make JSONTableWriter fail if no index.name and 'index' in columns

This commit is itended to fix GH pandas-dev#58925. If index.name is empty it will
use set_default_names inside __init__ to make check on overlapping names
fail. Otherwise it's done during schema creation and not reflected on
the dataframe itself which creates inconsistency between the data and
its schema.

Author: taranarmo

doc/source/whatsnew/v3.0.0.rst

@@ -548,6 +548,7 @@ I/O
 - Bug in :meth:`DataFrame.to_string` that raised ``StopIteration`` with nested DataFrames. (:issue:`16098`)
 - Bug in :meth:`read_csv` raising ``TypeError`` when ``index_col`` is specified and ``na_values`` is a dict containing the key ``None``. (:issue:`57547`)
 - Bug in :meth:`read_stata` raising ``KeyError`` when input file is stored in big-endian format and contains strL data. (:issue:`58638`)
+- Bug in :meth:`.DataFrame.to_json` was producing corrupted record (data incompatible with schema) if 'index' was the name of a column and index.name was empty (which is replaced with generic 'index' internally), now it will fail on check if index.name is in columns (:issue:`58925`)
 
 Period
 ^^^^^^

pandas/io/json/_json.py

@@ -60,6 +60,7 @@
 from pandas.io.json._table_schema import (
     build_table_schema,
     parse_table_schema,
+    set_default_names,
 )
 from pandas.io.parsers.readers import validate_integer
 
@@ -352,7 +353,10 @@ def __init__(
             )
             raise ValueError(msg)
 
+        obj = obj.copy()
         self.schema = build_table_schema(obj, index=self.index)
+        if self.index:
+            obj = set_default_names(obj)
 
         # NotImplemented on a column MultiIndex
         if obj.ndim == 2 and isinstance(obj.columns, MultiIndex):
@@ -369,7 +373,6 @@ def __init__(
             msg = "Overlapping names between the index and columns"
             raise ValueError(msg)
 
-        obj = obj.copy()
         timedeltas = obj.select_dtypes(include=["timedelta"]).columns
         if len(timedeltas):
             obj[timedeltas] = obj[timedeltas].map(lambda x: x.isoformat())

pandas/tests/io/json/test_pandas.py

@@ -1610,6 +1610,13 @@ def test_to_json_from_json_columns_dtypes(self, orient):
         )
         tm.assert_frame_equal(result, expected)
 
+    def test_to_json_with_index_as_a_column_name(self):
+        df = DataFrame(data={"index": [1, 2], "a": [2, 3]})
+        with pytest.raises(
+            ValueError, match="Overlapping names between the index and columns"
+        ):
+            df.to_json(orient="table")
+
     @pytest.mark.parametrize("dtype", [True, {"b": int, "c": int}])
     def test_read_json_table_dtype_raises(self, dtype):
         # GH21345