Display a different warning when trying to copy from an unexisting directory or an invalid one

Author: Lyrkan

lib/config-generator.js

@@ -154,8 +154,13 @@ class ConfigGenerator {
                 entry.from
             );
 
-            if (!fs.existsSync(copyFrom) || !fs.lstatSync(copyFrom).isDirectory()) {
-                logger.warning(`The "from" option of copyFiles() should be set to an existing directory but "${entry.from}" does not seem to be one. No file will be copied for this entry.`);
+            if (!fs.existsSync(copyFrom)) {
+                logger.warning(`The "from" option of copyFiles() should be set to an existing directory but "${entry.from}" does not seem to exist. Nothing will be copied for this copyFiles() config object.`);
+                return false;
+            }
+
+            if (!fs.lstatSync(copyFrom).isDirectory()) {
+                logger.warning(`The "from" option of copyFiles() should be set to an existing directory but "${entry.from}" seems to be a file. Nothing will be copied for this copyFiles() config object.`);
                 return false;
             }
 

test/functional.js

@@ -1621,7 +1621,7 @@ module.exports = {
                     to: 'assets/[path][name].[ext]',
                     includeSubdirectories: false
                 }, {
-                    from: './bar/baz',
+                    from: './images/symfony_logo.png',
                     includeSubdirectories: true
                 }]);
 
@@ -1634,8 +1634,8 @@ module.exports = {
                             'manifest.json'
                         ]);
 
-                    expect(stdout).to.contain('should be set to an existing directory but "./foo" does not seem to be one');
-                    expect(stdout).to.contain('should be set to an existing directory but "./bar/baz" does not seem to be one');
+                    expect(stdout).to.contain('should be set to an existing directory but "./foo" does not seem to exist');
+                    expect(stdout).to.contain('should be set to an existing directory but "./images/symfony_logo.png" seems to be a file');
 
                     done();
                 });