Skip to content

Commit 1d22520

Browse files
committed
Don't set hmr option for mini-css-extract-plugin (deprecated since 1.0.0)
1 parent 564b147 commit 1d22520

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

Diff for: lib/loaders/css-extract.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,11 @@ module.exports = {
3636
}
3737

3838
// Default options
39-
const options = {
40-
hmr: webpackConfig.useHotModuleReplacementPlugin(),
41-
};
42-
4339
return [{
4440
loader: MiniCssExtractPlugin.loader,
4541
options: applyOptionsCallback(
4642
webpackConfig.miniCssExtractLoaderConfigurationCallback,
47-
options
43+
{}
4844
),
4945
}, ...loaders];
5046
}

Diff for: test/loaders/css-extract.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ describe('loaders/css-extract', () => {
3131

3232
expect(loaders).to.have.lengthOf(2);
3333
expect(loaders[0].loader).to.equal(MiniCssExtractPlugin.loader);
34-
expect(loaders[0].options.hmr).to.be.false;
3534
});
3635

3736
it('prependLoaders() with CSS extraction disabled', () => {
@@ -48,13 +47,13 @@ describe('loaders/css-extract', () => {
4847
it('prependLoaders() options callback', () => {
4948
const config = createConfig();
5049
config.configureMiniCssExtractPlugin(options => {
51-
options.hmr = true;
50+
options.ignoreOrder = true;
5251
});
5352

5453
const loaders = cssExtractLoader.prependLoaders(config, ['foo']);
5554

5655
expect(loaders).to.have.lengthOf(2);
5756
expect(loaders[0].loader).to.equal(MiniCssExtractPlugin.loader);
58-
expect(loaders[0].options.hmr).to.be.true;
57+
expect(loaders[0].options.ignoreOrder).to.be.true;
5958
});
6059
});

0 commit comments

Comments
 (0)