Adding a warning of you accidentally override a core cache group

Author: weaverryan

lib/config/validator.js

@@ -26,6 +26,8 @@ class Validator {
         this._validatePublicPathAndManifestKeyPrefix();
 
         this._validateDevServer();
+
+        this._validateSharedEntryName();
     }
 
     _validateBasic() {
@@ -66,6 +68,12 @@ class Validator {
             logger.warning(`Passing an absolute URL to setPublicPath() *and* using the dev-server can cause issues. Your assets will load from the publicPath (${this.webpackConfig.publicPath}) instead of from the dev server URL (${this.webpackConfig.runtimeConfig.devServerUrl}).`);
         }
     }
+
+    _validateSharedEntryName() {
+        if (['vendors', 'default'].includes(this.webpackConfig.sharedCommonsEntryName)) {
+            logger.warning(`Passing "${this.webpackConfig.sharedCommonsEntryName}" to createSharedEntry() is not recommended, as it will override the built-in cache group by this name.`);
+        }
+    }
 }
 
 module.exports = function(webpackConfig) {

test/config/validator.js

@@ -82,4 +82,18 @@ describe('The validator function', () => {
         expect(logger.getMessages().warning).to.have.lengthOf(1);
         expect(logger.getMessages().warning[0]).to.include('Passing an absolute URL to setPublicPath() *and* using the dev-server can cause issues');
     });
+
+    it('warning with createSharedEntry() and core cache group name', () => {
+        const config = createConfig();
+        config.outputPath = '/tmp/public/build';
+        config.setPublicPath('/build');
+        config.createSharedEntry('vendors', './main');
+
+        logger.reset();
+        logger.quiet();
+        validator(config);
+
+        expect(logger.getMessages().warning).to.have.lengthOf(1);
+        expect(logger.getMessages().warning[0]).to.include('Passing "vendors" to createSharedEntry() is not recommended');
+    });
 });